[16.0][ADD] account_statement_import_online_plaid

[adasatorres]

This addon allow get your transactions using plaid.com platform.

[Christian-RB]

Great solution for bank statements import in USA 👍🏻

[lauradiaz22]

Functional test OK. LGTM!

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[etobella]

Technically seems correct, however, I would make a small change

[carolinafernandez-tecnativa]

Hi,

1- I have created new journal with this configuration:

When i press Pull online i got this error message:

But the record exists:

[adasatorres]

Hi,

1- I have created new journal with this configuration:

When i press Pull online i got this error message:

But the record exists:

Hello @carolinafernandez-tecnativa , sorry for the delay. I have checked the mentioned issue, and it seems to be unrelated to this addon, as the problem persists even after uninstalling this addon in the runboat.

[jelenapoblet]

@pedrobaeza @etobella anything else we need here to push this through ?

[rrebollo]

@adasatorres @pedrobaeza @etobella I'm starting the migration to v17 from this PR. As this is not merged yet, is there any guidelines to follow?

[rrebollo]

Code Review LGTM

[rrebollo]

I miss the plaid-python version before. Please accept my suggestion.

[pedrobaeza]

Checking these days. Please wait a bit.

[ayushin]

For international companies using banks in different country action_sync_with_plaid would work better with:

        country_code = self.journal_id.bank_id.country.code or self.env.user.company_id.country_id.code

[pedrobaeza]

This doesn't serve without Plaid giving the prod API keys, which is not easy and very pricey, so it shouldn't be merged for not creating false expectations.

[ayushin]

That's not correct, Plaid prod API keys for transactions are possible on entry tier - my company pays less than a dollar a month for 10 accounts

[pedrobaeza]

Well, I want to know how can that possible nowadays. I wasn't able. Maybe you have some instructions to follow?

[ayushin]

@pedrobaeza You just choose "Pay As You Go" plan and that's it.

[pedrobaeza]

I requested that, but still no access:

And same things seem to happen for others: https://www.reddit.com/r/fintech/comments/bxhvs3/plaid_pay_as_you_go_pricing/?rdt=52816

[jelenapoblet]

Hi, i managed to get approved by following the instructions:

[ayushin]

from my side, I've tested and everything works. the only issue i had is that the bank is in the different country than my company and i suggested a fix above, other than that it all seem to work

[lauradiaz22]

Good morning,

I have tested this PR repeatedly and it's performance has always been correct. This LGTM👍

[pedrobaeza]

Suggested change

	country_code = country_code = (
	self.journal_id.bank_id.country.code
	or self.env.user.company_id.country_id.code
	)
	country_code = country_code = (
	self.journal_id.company_id.country_id.code
	or self.env.company.country_id.code
	)

[adasatorres]

Good afternoon @pedrobaeza , why not use the country code configured in the bank specified in the journal? In my opinion, I think it's a good idea since you could have banks in different countries than your company. Additionally, I have been researching, and it is recommended to use the country or region code where the bank you are connecting to operates. For example, to determine the available financial institutions, configure the environment and ensure regulatory compliance, select the language and currency, define the structure of banking credentials, and so on.

[pedrobaeza]

You may not have the bank defined. And is country a field in standard Odoo or is it something of l10n_es_partner? At minimum, you need to put that fallback to company's country.

[adasatorres]

The country field in the bank_id comes from the base module. I understand the possibility that the journal might not have an associated bank, but in that case, the company's country can be used as a default.

[pedrobaeza]

OK about the first one, but the fallback is incorrect. self.env.user.company_id is not the current company, but the default company of the user. You have to use self.env.company.country_id.code instead, and I insist that the first fallback must be the company's journal, as you may have selected several companies at the same time, and being linking a journal not from the main company, so self.env.company won't be correct as well.

[adasatorres]

Yes, you're right. It doesn't make sense to use the country code of either the user or the current company. The company associated with the journal should be used.

[adasatorres]

Would it be a good idea to configure a system parameter with a default country code? There will always be a possibility that the country field is False.

[pedrobaeza]

The country is mandatory in the company, so I don't think so. You shouldn't over-complicate this case. If you want, you can issue a UserError if no country code as a way to stop the process.

[adasatorres]

For international companies using banks in different country action_sync_with_plaid would work better with:

        country_code = self.journal_id.bank_id.country.code or self.env.user.company_id.country_id.code

@ayushin Good morning, and thank you for the suggestion, I just added it.

@rrebollo Can you add this suggestion to the following PR? #742

[rrebollo]

@adasatorres can you pin me when the requested changes are done, to forward-port them to v17 PR.

[adasatorres]

Good morning @rrebollo ,

The changes have already been uploaded; I just need to add a test for the new method I created, which is called _check_country. Additionally, I need to modify the translation file for the exception string. I’ll let you know as soon as I have those changes ready.

[jelenapoblet]

Hi @adasatorres , while testing in a live environment, I noticed that when the user has the English language set, the following error occurs:

[adasatorres]

Hi @jelenapoblet , when I get a chance, I will review it. There are languages that Plaid does not support, but US English should work . I need to create a method to verify those languages.