[16][FIX] account_statement_import_online_paypal : search transaction with a 1 second margin to ensure it is found #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h a 1 second margin to ensure it is found
|
Hi @alexey-pelykh, |
ntsirintanis
approved these changes
Nov 4, 2024
|
This PR has the |
houssine78
approved these changes
Dec 24, 2024
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 0049b44. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #726 as proposed by @Roodin
I propose it here so it is usable for people having this issue, but it may not be the best way.
I do not really know the module so I do not try something else but I do not understand why this is important : https://github.com/OCA/bank-statement-import/blob/16.0/account_statement_import_online_paypal/models/online_bank_statement_provider_paypal.py#L235
Don't we have already the transaction in
first_transactionvariable?, why do we need to fetch it once again ?Maybe @alexey-pelykh could enlighten me ?