Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] account_statement_import_online_gocardless : fix typing error… #746

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

arpol-dev
Copy link
Contributor

@arpol-dev arpol-dev commented Dec 13, 2024

… in wizard/online_bank_statement_provider_existing.py new_link method. link

Fixes #745

@pedrobaeza pedrobaeza added this to the 16.0 milestone Dec 13, 2024
@pedrobaeza pedrobaeza changed the title [FIX #745] account_statement_import_online_gocardless : fix typing error… [16.0][FIX] account_statement_import_online_gocardless : fix typing error… Dec 13, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the commit message doesn't follow strictly the guidelines:

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

but it's very similar, and for not being picky, let's fast-track it to solve the problem:

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-746-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b304028 into OCA:16.0 Dec 13, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3958cfc. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gocardless : typing error in the "New link" method call
3 participants