Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] account_statement_import_sheet_file: Reset fields based on the selected 'amount_type' value when its change #757

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

rov-adhoc
Copy link

When 'amount_type' is changed, related fields (such as amount_debit_column,amount_credit_column,debit_credit_column,amount_column) are not cleared, leading to potential inconsistencies in the values.

This commit fixes the issue by ensuring that when 'amount_type' is set to a new value, all the related fields are reset accordingly to avoid any residual values.

Steps to reproduce:

  1. Start with the amount_type field set to "Simple Value", and ensure the "Amount Column" field is correctly configured, for example, with the value "Amount".
  2. Change the amount_type field to "Distinct Credit/Debit Column", and set values for the "Debit Amount Column" and "Credit Amount Column" fields, for example, "Debit" and "Credit", respectively.
  3. Observe that the previously configured "Amount Column" field is not cleared, leading to potential inconsistencies in the data.

With this fix, related fields such as 'amount_column','debit_credit_column', 'amount_debit_column', and 'amount_credit_column' are correctly reset when 'amount_type' changes.

Video with the issue
Video

@OCA-git-bot
Copy link
Contributor

Hi @alexey-pelykh,
some modules you are maintaining are being modified, check this out!

…selected 'amount_type' value when its change
@gonzalolenzi
Copy link

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants