Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] brand_external_report_layout #205

Open
wants to merge 43 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] brand_external_report_layout #205

wants to merge 43 commits into from

Conversation

antonioburic
Copy link
Member

No description provided.

sbejaoui and others added 30 commits July 7, 2024 21:50
@sbejaoui @antonioburic
[12.0][IMP] - manage different report layouts by brand
30e0a29
@sbejaoui @antonioburic
[12.0][IMP] - Add unit tests
18a990a
@sbejaoui @antonioburic
[12.0][IMP] - Add ROADMAP file to readme
0561d0a
@sbejaoui @antonioburic
[12.0][RMV] - Remove useless section in readme
d84492f
@sbejaoui @sbidoul @antonioburic
[12.0][IMP] - Change field label
5503971 
Co-Authored-By: Stéphane Bidoul (ACSONE) <stephane.bidoul@acsone.eu>
@OCA-git-bot @antonioburic
[ADD] icon.png
eaf7355
@OCA-git-bot @antonioburic
brand_external_report_layout 12.0.1.0.1
a4fa9c3
@jguenat @antonioburic
[12.0][FIX]-report_template
dea4a99
@OCA-git-bot @antonioburic
brand_external_report_layout 12.0.1.0.2
39d17fb
@cubells @antonioburic
[MIG] brand_external_report_layout: Migration to 13.0
11cf9f3
@Freni-OSI @antonioburic
[14.0][MIG] brand_external_report_layout
5ff34ce
@oca-travis @antonioburic
[UPD] Update brand_external_report_layout.pot
628bfff
@OCA-git-bot @antonioburic
[UPD] README.rst
94796bb
@Murtaza-SerpentCS @antonioburic
[14.0][FIX] brand_external_report_layout.
8e63513
@sbejaoui @antonioburic
pre-commit
9551d05
@OCA-git-bot @antonioburic
brand_external_report_layout 14.0.1.0.1
163dfba
@sbejaoui @antonioburic
[IMP] - add Brand Document Layout
b0715cc
@sbejaoui @antonioburic
[MIG] - brand_external_report_layout migration 15.0
bc9208e
@antonioburic
[UPD] Update brand_external_report_layout.pot
30a79bb
@OCA-git-bot @antonioburic
[UPD] README.rst
d80cfb1
@sbejaoui @antonioburic
[16.0][MIG] - migration brand_external_report_layout to 16.0
025c45a
@antonioburic
[UPD] Update brand_external_report_layout.pot
0a980d9
@OCA-git-bot @antonioburic
[UPD] README.rst
16097a7
@antonioburic
[UPD] Update brand_external_report_layout.pot
4d9e5e0
@antonioburic
[UPD] Update brand_external_report_layout.pot
50d7df7
@antonioburic
[UPD] Update brand_external_report_layout.pot
edcb665
@badbole @antonioburic
Added translation using Weblate (Croatian)
55e4533
@badbole @antonioburic
Translated using Weblate (Croatian)
61edd56 
Currently translated at 96.0% (48 of 50 strings)

Translation: brand-16.0/brand-16.0-brand_external_report_layout
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-brand_external_report_layout/hr/
@antonioburic
[UPD] Update brand_external_report_layout.pot
c0491bb
@weblate @antonioburic
Update translation files
def7ca7 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: brand-16.0/brand-16.0-brand_external_report_layout
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-brand_external_report_layout/
ibuioli and others added 10 commits July 7, 2024 21:50
@ibuioli @antonioburic
Added translation using Weblate (Spanish (Argentina))
69f2196
@ibuioli @antonioburic
Translated using Weblate (Spanish (Argentina))
50dfae8 
Currently translated at 100.0% (51 of 51 strings)

Translation: brand-16.0/brand-16.0-brand_external_report_layout
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-brand_external_report_layout/es_AR/
@Ivorra78 @antonioburic
Added translation using Weblate (Spanish)
81302ba
@Ivorra78 @antonioburic
Translated using Weblate (Spanish)
d8b7428 
Currently translated at 100.0% (51 of 51 strings)

Translation: brand-16.0/brand-16.0-brand_external_report_layout
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-brand_external_report_layout/es/
@OCA-git-bot @antonioburic
[UPD] README.rst
20773d1
@weblate @antonioburic
Update translation files
107869c 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: brand-16.0/brand-16.0-brand_external_report_layout
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-brand_external_report_layout/
@Sibert-Aerts @antonioburic
[FIX] Add missing sudo() in template
3b11e49
@OCA-git-bot @antonioburic
[BOT] post-merge updates
83869cc
@mymage @antonioburic
Added translation using Weblate (Italian)
1c81356
@antonioburic
[IMP] brand_external_report_layout: apply pre-commit auto fixes
20b74d9
@antonioburic antonioburic mentioned this pull request Jul 7, 2024
Open
11 tasks
@CasVissers-360ERP
Copy link

@antonioburic can you include #195

CasVissers-360ERP
CasVissers-360ERP approved these changes Aug 14, 2024
View reviewed changes
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

antonioburic and others added 2 commits October 1, 2024 09:00
@antonioburic
[MIG] brand_external_report_layout: Migration to 17.0
9242064
@RemiFr82 @antonioburic
[ADD] is_company_detail_empty Boolean on res.brand
c9eda59 
The field works like on res.company model

[FIX] add missing import

[IMP] formatting
@antonioburic antonioburic force-pushed the 17.0-mig-brand_external_report_layout branch from a4d0a03 to c9eda59 Compare October 1, 2024 07:01
bosd
bosd suggested changes Nov 3, 2024
View reviewed changes
Copy link

@bosd bosd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this.
During functional test, I was unable to produce a branded pdf.

Steps to reproduce on runboat

  1. Go to Settings > Users & Companies > Brands
  2. Add a new brand
  3. Upload a logo, enter some info click change document template..
  4. Change some color.
  5. See the changed document on the form..
  6. Click Download PDF Preview
  7. Open the downloaded pdf. The changes made to the standard document are not visible.

@bosd
Copy link

bosd commented Nov 7, 2024 •
edited
Loading

Please include #201
Edit: better wait on that one

sbejaoui
sbejaoui approved these changes Jan 1, 2025
View reviewed changes
Copy link
Contributor

@sbejaoui sbejaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review

@sbejaoui @bosd
[FIX] fix typo in remade
d91c1a0 
Co-authored-by: bosd <11499387+bosd@users.noreply.github.com>
@sbejaoui
Copy link
Contributor

sbejaoui commented Jan 1, 2025

Thanks for your work on this. During functional test, I was unable to produce a branded pdf.

To test this, you need to install either the sale_brand or account_brand module.

@lauradiaz22
Copy link

Good morning,

I have tried to test this PR but it is impossible for me if I can't install the sale_brand or account_brand addon. And when I access to the application module to install it, it doesn't appear. Could you please upload those modules or any of them to test the PR at a functional level correctly?

Thank you very much in advance.

@bosd
Copy link

bosd commented Jan 15, 2025

To test this, you need to install either the sale_brand or account_brand module.

I know, that could be used as well.
But any chance to support the preview document as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosd bosd bosd requested changes

@espo-tony espo-tony espo-tony requested changes

@CasVissers-360ERP CasVissers-360ERP CasVissers-360ERP approved these changes

@sbejaoui sbejaoui sbejaoui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.