[15.0][MIG]business_requirement_sale:Migration to 15.0

.copier-answers.yml

@@ -1,8 +1,9 @@
 # Do NOT update manually; changes here will be overwritten by Copier
-_commit: v1.14.2
+_commit: v1.20
 _src_path: gh:oca/oca-addons-repo-template
+additional_ruff_rules: []
 ci: GitHub
-dependency_installation_mode: PIP
+convert_readme_fragments_to_markdown: true
 generate_requirements_txt: true
 github_check_license: true
 github_ci_extra_env: {}
@@ -11,6 +12,7 @@ github_enable_makepot: true
 github_enable_stale_action: true
 github_enforce_dev_status_compatibility: true
 include_wkhtmltopdf: false
+odoo_test_flavor: Both
 odoo_version: 15.0
 org_name: Odoo Community Association (OCA)
 org_slug: OCA
@@ -19,6 +21,6 @@ repo_description: 'TODO: add repo description.'
 repo_name: business-requirement
 repo_slug: business-requirement
 repo_website: https://github.com/OCA/business-requirement
-travis_apt_packages: []
-travis_apt_sources: []
+use_pyproject_toml: false
+use_ruff: true
 

.eslintrc.yml

@@ -22,6 +22,7 @@ globals:
   odoo: readonly
   openerp: readonly
   owl: readonly
+  luxon: readonly
 
 # Styling is handled by Prettier, so we only need to enable AST rules;
 # see https://github.com/OCA/maintainer-quality-tools/pull/618#issuecomment-558576890

.github/workflows/pre-commit.yml

@@ -13,8 +13,10 @@ jobs:
   pre-commit:
     runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - uses: actions/setup-python@v2
+        with:
+          python-version: "3.11"
       - name: Get python version
         run: echo "PY=$(python -VV | sha256sum | cut -d' ' -f1)" >> $GITHUB_ENV
       - uses: actions/cache@v1
@@ -25,6 +27,15 @@ jobs:
         run: pip install pre-commit
       - name: Run pre-commit
         run: pre-commit run --all-files --show-diff-on-failure --color=always
+        env:
+          # Consider valid a PR that changes README fragments but doesn't
+          # change the README.rst file itself. It's not really a problem
+          # because the bot will update it anyway after merge. This way, we
+          # lower the barrier for functional contributors that want to fix the
+          # readme fragments, while still letting developers get README
+          # auto-generated (which also helps functionals when using runboat).
+          # DOCS https://pre-commit.com/#temporarily-disabling-hooks
+          SKIP: oca-gen-addon-readme
       - name: Check that all files generated by pre-commit are in git
         run: |
           newfiles="$(git ls-files --others --exclude-from=.gitignore)"

.github/workflows/test.yml

@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Detect unreleased dependencies
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - run: |
           for reqfile in requirements.txt test-requirements.txt ; do
               if [ -f ${reqfile} ] ; then
@@ -36,10 +36,10 @@ jobs:
       matrix:
         include:
           - container: ghcr.io/oca/oca-ci/py3.8-odoo15.0:latest
-            makepot: "true"
             name: test with Odoo
           - container: ghcr.io/oca/oca-ci/py3.8-ocb15.0:latest
             name: test with OCB
+            makepot: "true"
     services:
       postgres:
         image: postgres:9.6
@@ -50,7 +50,7 @@ jobs:
         ports:
           - 5432:5432
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           persist-credentials: false
       - name: Install addons and dependencies

.gitignore

@@ -3,6 +3,7 @@ __pycache__/
 *.py[cod]
 /.venv
 /.pytest_cache
+/.ruff_cache
 
 # C extensions
 *.so

.pre-commit-config.yaml

@@ -12,6 +12,10 @@ exclude: |
   /static/(src/)?lib/|
   # Repos using Sphinx to generate docs don't need prettying
   ^docs/_templates/.*\.html$|
+  # Don't bother non-technical authors with formatting issues in docs
+  readme/.*\.(rst|md)$|
+  # Ignore build and dist directories in addons
+  /build/|/dist/|
   # You don't usually want a bot to modify your legal texts
   (LICENSE.*|COPYING.*)
 default_language_version:
@@ -33,27 +37,26 @@ repos:
         language: fail
         files: '[a-zA-Z0-9_]*/i18n/en\.po$'
   - repo: https://github.com/oca/maintainer-tools
-    rev: dfba427ba03900b69e0a7f2c65890dc48921d36a
+    rev: 9a170331575a265c092ee6b24b845ec508e8ef75
     hooks:
       # update the NOT INSTALLABLE ADDONS section above
       - id: oca-update-pre-commit-excluded-addons
       - id: oca-fix-manifest-website
         args: ["https://github.com/OCA/business-requirement"]
-  - repo: https://github.com/myint/autoflake
-    rev: v1.4
-    hooks:
-      - id: autoflake
+      - id: oca-gen-addon-readme
         args:
-          - --expand-star-imports
-          - --ignore-init-module-imports
-          - --in-place
-          - --remove-all-unused-imports
-          - --remove-duplicate-keys
-          - --remove-unused-variables
-  - repo: https://github.com/psf/black
-    rev: 22.3.0
+          - --addons-dir=.
+          - --branch=15.0
+          - --org-name=OCA
+          - --repo-name=business-requirement
+          - --if-source-changed
+          - --keep-source-digest
+          - --convert-fragments-to-markdown
+  - repo: https://github.com/OCA/odoo-pre-commit-hooks
+    rev: v0.0.25
     hooks:
-      - id: black
+      - id: oca-checks-odoo-module
+      - id: oca-checks-po
   - repo: https://github.com/pre-commit/mirrors-prettier
     rev: v2.4.1
     hooks:
@@ -95,19 +98,6 @@ repos:
       - id: check-xml
       - id: mixed-line-ending
         args: ["--fix=lf"]
-  - repo: https://github.com/asottile/pyupgrade
-    rev: v2.29.0
-    hooks:
-      - id: pyupgrade
-        args: ["--keep-percent-format"]
-  - repo: https://github.com/PyCQA/isort
-    rev: 5.12.0
-    hooks:
-      - id: isort
-        name: isort except __init__.py
-        args:
-          - --settings=.
-        exclude: /__init__\.py$
   - repo: https://github.com/acsone/setuptools-odoo
     rev: 3.1.8
     hooks:
@@ -118,14 +108,14 @@ repos:
           - requirements.txt
           - --header
           - "# generated from manifests external_dependencies"
-  - repo: https://github.com/PyCQA/flake8
-    rev: 3.9.2
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.1.3
     hooks:
-      - id: flake8
-        name: flake8
-        additional_dependencies: ["flake8-bugbear==21.9.2"]
+      - id: ruff
+        args: [--fix, --exit-non-zero-on-fix]
+      - id: ruff-format
   - repo: https://github.com/OCA/pylint-odoo
-    rev: 7.0.2
+    rev: 7.0.5
     hooks:
       - id: pylint_odoo
         name: pylint with optional checks

.ruff.toml

@@ -0,0 +1,30 @@
+
+target-version = "py38"
+fix = true
+
+[lint]
+extend-select = [
+    "B",
+    "C90",
+    "E501",  # line too long (default 88)
+    "I",  # isort
+    "UP",  # pyupgrade
+]
+exclude = ["setup/*"]
+
+[format]
+exclude = ["setup/*"]
+
+[per-file-ignores]
+"__init__.py" = ["F401", "I001"]  # ignore unused and unsorted imports in __init__.py
+"__manifest__.py" = ["B018"]  # useless expression
+
+[isort]
+section-order = ["future", "standard-library", "third-party", "odoo", "odoo-addons", "first-party", "local-folder"]
+
+[isort.sections]
+"odoo" = ["odoo"]
+"odoo-addons" = ["odoo.addons"]
+
+[mccabe]
+max-complexity = 16

business_requirement/README.rst

@@ -28,38 +28,42 @@ Business Requirement
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
 
-A **Business requirement** (BR) is the expression of a business need by a customer
-or internal project user.
-
-A BR contains multiple different parts to explain the stakeholder need and how to
-meet his/her requirements:
-
-* **Customer Story**: this is the requirement as expressed by the customer
-* **Scenario**: How/where the current solution can provide a suitable scenario to
-  answer the customer story
-* **Gap**: For the uncovered part of the scenario, elaborate the gap/need for specific
-  developments/setup
-* **Test case**: A set of conditions under which a tester will determine whether the application, software system or
-  one of its features is working as it was originally established for it to do.
-* **Deliverables** to be provided to the customer/user
-* **Resources** necessary to achieve the deliverables
-* **Additional** information (approval, cost control etc.)
-
-This set of modules was originally designed for the service/IT industry but the
-requirement management design has been kept as generic as possible so that it can
-apply to many other cases/industries (customer or internal projects):
-
-* Construction
-* Trading (New product development)
-* Business Consultancy
-* Web or IT development
-* R&D projects
-* etc.
+A **Business requirement** (BR) is the expression of a business need by
+a customer or internal project user.
+
+A BR contains multiple different parts to explain the stakeholder need
+and how to meet his/her requirements:
+
+-  **Customer Story**: this is the requirement as expressed by the
+   customer
+-  **Scenario**: How/where the current solution can provide a suitable
+   scenario to answer the customer story
+-  **Gap**: For the uncovered part of the scenario, elaborate the
+   gap/need for specific developments/setup
+-  **Test case**: A set of conditions under which a tester will
+   determine whether the application, software system or one of its
+   features is working as it was originally established for it to do.
+-  **Deliverables** to be provided to the customer/user
+-  **Resources** necessary to achieve the deliverables
+-  **Additional** information (approval, cost control etc.)
+
+This set of modules was originally designed for the service/IT industry
+but the requirement management design has been kept as generic as
+possible so that it can apply to many other cases/industries (customer
+or internal projects):
+
+-  Construction
+-  Trading (New product development)
+-  Business Consultancy
+-  Web or IT development
+-  R&D projects
+-  etc.
 
 More information about business requirements management:
 
-* `Wikipedia <https://en.wikipedia.org/wiki/Business_requirements>`_
-* `Six Sigma <https://www.isixsigma.com/implementation/project-selection-tracking/business-requirements-document-high-level-review/>`_
+-  `Wikipedia <https://en.wikipedia.org/wiki/Business_requirements>`__
+-  `Six
+   Sigma <https://www.isixsigma.com/implementation/project-selection-tracking/business-requirements-document-high-level-review/>`__
 
 **Table of contents**
 
@@ -80,39 +84,39 @@ Credits
 =======
 
 Authors
-~~~~~~~
+-------
 
 * Elico Corp
 * Tecnativa
 
 Contributors
-~~~~~~~~~~~~
+------------
 
-* Eric Caudal <eric.caudal@elico-corp.com>
-* Alex Duan <alex.duan@elico-corp.com>
-* Xie XiaoPeng <xie.xiaopeng@elico-corp.com>
-* Victor M. Martin <victor.martin@elico-corp.com>
-* Evan Li <li.aiwen@elico-corp.com>
-* Reinhard Sheng <reinhard.sheng@elico-corp.com>
+-  Eric Caudal <eric.caudal@elico-corp.com>
+-  Alex Duan <alex.duan@elico-corp.com>
+-  Xie XiaoPeng <xie.xiaopeng@elico-corp.com>
+-  Victor M. Martin <victor.martin@elico-corp.com>
+-  Evan Li <li.aiwen@elico-corp.com>
+-  Reinhard Sheng <reinhard.sheng@elico-corp.com>
+-  `Tecnativa <https://www.tecnativa.com>`__:
 
-* `Tecnativa <https://www.tecnativa.com>`_:
-
-  * Alexandre Diaz
-  * Pedro M. Baeza
-  * Victor M.M. Torres
-  * Víctor Martínez
+   -  Alexandre Diaz
+   -  Pedro M. Baeza
+   -  Victor M.M. Torres
+   -  Víctor Martínez
 
 Other credits
-~~~~~~~~~~~~~
-
+-------------
 
-* Images:
+-  Images:
 
-  * `briefcase <https://fontawesome.com/icons/briefcase?style=solid>`__ from `FontAwesome <https://fontawesome.com/license>`__.
-  * `drafting-compass <https://fontawesome.com/icons/drafting-compass?style=solid>`__ from `FontAwesome <https://fontawesome.com/license>`__.
+   -  `briefcase <https://fontawesome.com/icons/briefcase?style=solid>`__
+      from `FontAwesome <https://fontawesome.com/license>`__.
+   -  `drafting-compass <https://fontawesome.com/icons/drafting-compass?style=solid>`__
+      from `FontAwesome <https://fontawesome.com/license>`__.
 
 Maintainers
-~~~~~~~~~~~
+-----------
 
 This module is maintained by the OCA.
 

business_requirement/controllers/portal.py

@@ -7,6 +7,8 @@
 from odoo.addons.portal.controllers.portal import (
     CustomerPortal,
     get_records_pager,
+)
+from odoo.addons.portal.controllers.portal import (
     pager as portal_pager,
 )