Sales commission so based module #471
Conversation
|
@pedrobaeza Hi, the module is ready. Do I need to do something extra? |
|
Formally, you can squash commits together, as they don't add value being unfolded. On the contributing process, at least 2 persons must review the PR, one of them being PSC: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review Unfortunately, I can't physically review every PR that enters OCA. You can enroll people to review your PR reviewing other existing PRs and asking in exchange that they review yours. |
� This is the 1st commit message: [ADD] sale_commission_so_based module � The commit message OCA#2 will be skipped: � [IMP] readme � The commit message OCA#3 will be skipped: � [REF] autoflake fixes, dependency added � The commit message OCA#4 will be skipped: � [FIX] Inline emphasis start-string without end-string. � The commit message OCA#5 will be skipped: � [FIX] Inline emphasis start-string without end-string. � The commit message OCA#6 will be skipped: � [REM] report_settlement_templates.xml � The commit message OCA#7 will be skipped: � [REF] import � The commit message OCA#8 will be skipped: � [REF] import � The commit message OCA#9 will be skipped: � [IMP] increase test coverage � The commit message OCA#10 will be skipped: � [IMP] pylint fixes � The commit message OCA#11 will be skipped: � [IMP] adopting for checks � The commit message OCA#12 will be skipped: � [IMP] adopting for checks
…' into sales_commission_so_based_module
|
@dcorio @joao-p-marques |
|
@maksymkv25 you should make sure PR is compliant with https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst before asking for reviews Also there is no documentation for this module, so functionals can't provide their opinion on whether it works or not |
|
Hello @maksymkv25 , Concerning documentation you should create a readme folder containing .rst files (USAGE.rst etc...). Then the oca bot will create the main README.rst automatically after merge (you can do it manually if you want https://github.com/OCA/maintainer-tools#readme-generator). |
|
This PR will be closed, because had a problem whit heads to squash commits. |
No description provided.