Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] sale_commission_product_criteria #571

Merged
merged 2 commits into from
Nov 5, 2024
Merged

[16.0][FIX] sale_commission_product_criteria #571

merged 2 commits into from
Nov 5, 2024

Conversation

toita86
Copy link

@toita86 toita86 commented Oct 21, 2024

Fw port of #568

@OCA-git-bot
Copy link
Contributor

Hi @ilyasProgrammer,
some modules you are maintaining are being modified, check this out!

francesco-ooops
francesco-ooops approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops
Copy link
Contributor

@pedrobaeza merge?

@pedrobaeza pedrobaeza added this to the 16.0 milestone Nov 5, 2024
@pedrobaeza
Copy link
Member

I don't know about this module. As there's a maintainer, he can merge it.

@francesco-ooops
Copy link
Contributor

@ilyasProgrammer can you merge please?

@ilyasProgrammer
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-571-by-ilyasProgrammer-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 090359c into OCA:16.0 Nov 5, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6ad15f0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbernausVunkers jbernausVunkers jbernausVunkers approved these changes

@francesco-ooops francesco-ooops francesco-ooops approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@toita86 @OCA-git-bot @francesco-ooops @pedrobaeza @ilyasProgrammer @jbernausVunkers @PicchiSeba