[14.0][IMP]sale_commission: save settlement wizard date in settlement #578
Conversation
|
Hi @pedrobaeza, |
aleuffre
force-pushed
the
14.0-settlement-wizard-dates
branch
from
e1896a7 to
3b1ef1f
Compare
There was a problem hiding this comment.
Functional ok!
@pedrobaeza this IMP follows this use case:
Settlements currently displays "Date from" and "Date to" which are taken from invoice date
With more complex setups (eg: commission types based on payment, settlement line created proportionally to payment received) these dates are not very relevant, as a settlement can be created in November 2024 for a payment received on an invoice from June 2024
These fields allow user to know the dates inputted in wizard to create settlement, eg:
"this settlement is for invoices issued from 1st to 30th of June 2024, based on invoices with date up to November 1st 2024 and payments received up to November 20th 2024"
|
@pedrobaeza is this change ok? |
|
This PR has the |
|
I don't really get this need. The creation date already allows to differentiate when the settlement is created, or switch to this approach: #519 |
|
@pedrobaeza in this specific case, I need to recreate all settlements at once, but I still want to be able to group them by invoice and payment date. Creation date is not a relevant value as all settlements would have current date. From what I understand, #519 is the opposite of what I'm looking for? It's hard to say as there's no rationale for the change or functional instructions. Anyway, it just makes sense to me that if some values can be selected in the wizard, they can then be saved in the record itself. Furthermore, we implemented the improvement as not to change anything in current flow, so I fail to see the reason to reject this PR. |
|
Then for your specific case, you should create an extra module on top doing that, instead of overloading the base module with more and more options and fields. |
No description provided.