Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] connector_importer: Migration to 18.0 #146

Merged
merged 202 commits into from
Oct 22, 2024
Merged

[18.0][MIG] connector_importer: Migration to 18.0 #146

merged 202 commits into from
Oct 22, 2024

Conversation

thienvh332
Copy link
Contributor

@thienvh332 thienvh332 force-pushed the 18.0-mig-connector_importer branch from 025f4df to bced517 Compare October 8, 2024 09:02
@thienvh332 thienvh332 marked this pull request as ready for review October 8, 2024 09:04
simahawk
simahawk requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's migration to v17 here... I guess the plan is to open a PR for that?

connector_importer/utils/mapper_utils.py
value = rel_model.search(search_args)

value = _handle_missing_values(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please split this change to its own commit so that we can backport it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can apply these changes on v16 if it eases your life and then we cherry-pick the commit ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simahawk ,

  • I don't have plans to make a PR for v17. And I've isolated the modifier change out so you can cherry-pick it easily.
  • Would you like me to create a PR to apply it to version 16?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simahawk ,

* I don't have plans to make a PR for v17. And I've isolated the modifier change out so you can cherry-pick it easily.

cool, tnx

* Would you like me to create a PR to apply it to version 16?

yes please, it will serve as a reminder 🙏

@simahawk
Copy link
Contributor

simahawk commented Oct 9, 2024

/ocabot migration connector_importer

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 9, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 9, 2024
Open
1 task
@thienvh332 thienvh332 force-pushed the 18.0-mig-connector_importer branch from bced517 to 020c9fc Compare October 9, 2024 11:29
@simahawk
Copy link
Contributor

a bunch of PRs to fwd port

@thienvh332 thienvh332 force-pushed the 18.0-mig-connector_importer branch from b939243 to 08d1f10 Compare October 10, 2024 09:49
@thienvh332 thienvh332 requested a review from simahawk October 10, 2024 10:10
@thienvh332 thienvh332 force-pushed the 18.0-mig-connector_importer branch from 08d1f10 to ab9e9f4 Compare October 11, 2024 04:58
@simahawk
Copy link
Contributor

TODO: rebase and drop test dep

simahawk and others added 17 commits October 21, 2024 09:11
@simahawk @thienvh332
[ADD] connector_importer
2ccc05d
@simahawk @thienvh332
[11.0] connector_importer
930304e
@simahawk @thienvh332
more tests and cleanup
e7d1fb1
@simahawk @thienvh332
fix tests
d2a5f38
@simahawk @thienvh332
make record handler and tracker real components
15513ca
@simahawk @thienvh332
connector_importer: add xmlid converter
03fa405
@simahawk @thienvh332
connector_importer: load mapper options on each chunk, log values debug
be8d406
@simahawk @thienvh332
c_importer: use serialized fields, add shared storage
2b58b24
@mpanarin @thienvh332
[FIX] invalidate_cache for set_shared (OCA#3)
6ed73b4 
* [FIX] invalidate_cache for set_shared

* fixup! [FIX] invalidate_cache for set_shared
@guewen @thienvh332
Correct method name in autogenerated cron
cf4fea3
@simahawk @thienvh332
Preserve original values on create/write
292c684
@simahawk @thienvh332
Record handler: allow force of create_uid/write_uid
99b98e2
@simahawk @thienvh332
Record handler: allow force of create_date
af2d152
@thienvh332
[FIX] check None instead of falsy on reporter
2d77732
@thienvh332
[FIX] base64 conversion
44a1ded
@thienvh332
[FIX] for csv writer as it expects a string in python3
f1882e1
@simahawk @thienvh332
Recordset importer: drop existing records before run
f59f150
simahawk and others added 6 commits October 21, 2024 09:11
@simahawk @thienvh332
connector_importer: allow rename keys via conf
ff65353 
You can now configure mapper options' key source_key_rename
to specify a mapping of keys to be renamed to match odoo field names.
@simahawk @thienvh332
connector_importer: improve job details
2ec984e
@OCA-git-bot @thienvh332
[BOT] post-merge updates
29fe53d
@mymage @thienvh332
Added translation using Weblate (Italian)
952999e
@mymage @thienvh332
Translated using Weblate (Italian)
299411f 
Currently translated at 100.0% (154 of 154 strings)

Translation: connector-interfaces-16.0/connector-interfaces-16.0-connector_importer
Translate-URL: https://translation.odoo-community.org/projects/connector-interfaces-16-0/connector-interfaces-16-0-connector_importer/it/
@thienvh332
[IMP] connector_importer: apply pre-commit auto fixes
4cf0bc1
@thienvh332 thienvh332 force-pushed the 18.0-mig-connector_importer branch from ab9e9f4 to cf0b05a Compare October 21, 2024 02:12
thienvh332 and others added 8 commits October 21, 2024 09:19
@thienvh332
[MIG] connector_importer: Migration to 18.0
395c932
@thienvh332
[IMP] connector_importer: fix modifier method is too complex
2f9cb9d
@Ricardoalso @thienvh332
connector_importer: Fix _run_import method to respect debug mode and …
292213f 
…use_job parameter

We want to handle debug mode and take into account the use_job parameter in order to spawn jobs only when requested
@Ricardoalso @thienvh332
Jobs are not spawn by default if not in debug mode
45019a7
@simahawk @thienvh332
connector_importer: add some docs :)
10e4b19
@Ricardoalso @thienvh332
connector_importer: define serialized fields as binary
4623236 
Replace the use of Serialized fields with Binary fields for report_data and shared_data in the ImportRecordset model. This change aims to improve performance and provide better storage management for large datasets.
@Ricardoalso @thienvh332
connector_importer: invalidate cache and flush pending computations
7a265eb
@thienvh332
[ADD] test-requirements.txt
3ac6d4f
@thienvh332 thienvh332 force-pushed the 18.0-mig-connector_importer branch from cf0b05a to 3ac6d4f Compare October 21, 2024 02:23
@simahawk
Copy link
Contributor

@thienvh332 can you drop test req? :)

@thienvh332
Copy link
Contributor Author

@thienvh332 can you drop test req? :)

Hi @simahawk ,

  • We need odoo_test_helper to be able to pass unit test. So I added test-requirement with a normal commit.
  • Of course, If you will be ok when it says test failed. I will drop it.

@simahawk
Copy link
Contributor

ahhh sorry, didn't check the content 😓
Cool, thanks then!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-146-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fa2c518 into OCA:18.0 Oct 22, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3f5ecc6. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmequignon mmequignon mmequignon approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.