Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes done in the all the appropriate model files according to the … #31

Open
wants to merge 2 commits into
base: 8.0
Choose a base branch
from

Conversation

techspawn1
Copy link

…new version of api available in woocommerce version 2.6.4

Fully compatible with woocommerce version(2.4.6)
Modified the process of import to get the list of the data
Modified the date time format in WOO_DATETIME_FORMAT

…new version of api available in woocommerce version 2.6.4

Fully compatible with woocommerce version(2.4.6)
Modified the process of import to get the list of the data
Modified the date time format in WOO_DATETIME_FORMAT
@pedrobaeza
Copy link
Member

Some comments:

  • Your changes are not compatible with old versions, so you must create another backend.
  • Don't replace logo with one with your own company.
  • Don't add extra lines on files that don't contain any other change.

@techspawn
Copy link

@pedrobaeza I have checked with the older versions of woo commerce i.e. 2.4.x and later versions . The code is fully compatible with all the older and newer version of woo commerce. While check the tests conducted by the auto build bot the test is failing because the woocommerce library has not been installed in runbot . So there is no need of creating new backend for our code, just need to replace the code that we have changed.

@pedrobaeza
Copy link
Member

Can you check Travis status?

@rafaelbn
Copy link
Member

rafaelbn commented Jul 3, 2017

Hi @techspawn1 @techspawn , is it possible to review travis errors and runbot errors in order to get this PR ready for review? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants