ADD module contract_fixed_discount #1009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damdam-s
force-pushed
the
14.0-add_fixed_discount_on_contract_line
branch
from
30fa2dc to
904c588
Compare
petrus-v
reviewed
Oct 20, 2023
damdam-s
force-pushed
the
14.0-add_fixed_discount_on_contract_line
branch
2 times, most recently
from
f2bd758 to
41a9d72
Compare
petrus-v
reviewed
Oct 20, 2023
|
|
||
| <field name="arch" type="xml"> | ||
| <field name="discount" position="after"> | ||
| <field name="discount_fixed" optional="hide" /> |
There was a problem hiding this comment.
testing on runboat :
- this looks like to manage the popup form view which which don't care about optional
- so we should add it on the tree view in the contract form view
- we should probably use same group as the discount fields
- I think we should change the group to rely on the same one present on sale order:
groups="product.group_discount_per_so_line"
damdam-s
force-pushed
the
14.0-add_fixed_discount_on_contract_line
branch
from
4f6e6e5 to
9f80be2
Compare
petrus-v
approved these changes
Oct 23, 2023
damdam-s
force-pushed
the
14.0-add_fixed_discount_on_contract_line
branch
from
9f80be2 to
d68f30a
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.