[14.0][FIX] contract: fix domain of payment_term_id field #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 7c93032. Thanks a lot for contributing to OCA. ❤️ |
marcelsavegnago
deleted the
14.0-contract-remove-domain-from-payment_term
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the domain is defined requires the creation of payment terms and the definition of the company to be able to select in the contract. I understand that in the case of this field it should also allow you to select payment terms that the company does not define.
Speaking of which, I could be wrong but I believe that check_company would already do the verification without the need for this domain.
domain="['|', ('company_id', '=', False), ('company_id', '=', company_id)]",
cc @alexis-via @douglascstd