Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] contract: Use %m instead of %B to obtain month #1168

Merged
merged 1 commit into from
Jan 7, 2025
Merged

[16.0][IMP] contract: Use %m instead of %B to obtain month #1168

merged 1 commit into from
Jan 7, 2025

Conversation

victoralmau
Copy link
Member

FWP from 15.0: #1163

Use %m instead of %B to obtain month

Related to #1153 Fixes #1160

Use the month number to set the text of the month and avoid problems according to the language defined in locale.

Please @pedrobaeza can you review it?

@Tecnativa

@victoralmau
[IMP] contract: Use %m instead of %B to obtain month
981543e 
Related to OCA#1153
Fixes OCA#1160

Use the month number to set the text of the month and avoid problems according
to the language defined in locale.
@Yvesldff
Copy link
Contributor

Yvesldff commented Jan 7, 2025

Tested in prod. Works well with french translation of month.
No error any more like "File "/odoo/custom/addons/contract/models/contract_line.py", line 614, in _translate_marker_month_name
return months[month_name]
KeyError: 'janvier'
"

pedrobaeza
pedrobaeza approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1168-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f22f697 into OCA:16.0 Jan 7, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 40cf8e0. Thanks a lot for contributing to OCA. ❤️

@victoralmau victoralmau mentioned this pull request Jan 7, 2025
Merged
@pedrobaeza pedrobaeza deleted the 16.0-imp-contract-issue1160 branch January 7, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosdauden carlosdauden carlosdauden approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@victoralmau @Yvesldff @OCA-git-bot @pedrobaeza @carlosdauden