[17.0][MIG] website_sale_secondary_unit: Migration to version 17.0 #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ice when product has secondary units defined
…ucts when "Add to cart" view is enabled.
As the product.secondary.unit view has been isolated, we have to inherit from that one.
…play unpublished secondary units. TT31018
complementary to OCA@3fa2331
Before this changes, the change in the value of the secondary unit input field didn't launch the execution of the onchanges of the real input field. Adding this changes, we achieve to capture the event of the new input field to launch the onchanges of the real input field. cc @Tecnativa TT29708
For mobile users adding an extra column in the cart summary makes that the others content won't fit very well, specially for products with long names. As we can infer the sale line information without the secondary units computation computation column we choose to hide it if the screen is too small as Odoo does with the product image column. TT37137
Currently translated at 53.3% (8 of 15 strings) Translation: e-commerce-15.0/e-commerce-15.0-website_sale_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_secondary_unit/it/
Currently translated at 100.0% (15 of 15 strings) Translation: e-commerce-15.0/e-commerce-15.0-website_sale_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_secondary_unit/es/
Currently translated at 100.0% (15 of 15 strings) Translation: e-commerce-15.0/e-commerce-15.0-website_sale_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_secondary_unit/it/
…antity description and delete column in purchase summary There were two quantity columns in the purchase summary, one with the secondary unit quantity and one with the product quantity. A quantity column in the purchase summary has been removed to give more clarity to the view. When product names or units of measure have a considerable number of characters, having two columns causes a crowding of the view and therefore a feeling of content clutter. Instead, their content has been moved so that both the secondary unit quantity and the quantity of product purchased appear in the same column. We have also added the option to hide the name of the secondary unit of measure in the secondary unit description template in case it matches the unit of measure of the product as depending on where it is being called from it can be redundant. TT45032
Currently translated at 100.0% (15 of 15 strings) Translation: e-commerce-15.0/e-commerce-15.0-website_sale_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_secondary_unit/it/
Currently translated at 100.0% (15 of 15 strings) Translation: e-commerce-15.0/e-commerce-15.0-website_sale_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_secondary_unit/es/
- Switch to setUpClass for avoiding repeat the same setup for each test. - Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (15 of 15 strings) Translation: e-commerce-15.0/e-commerce-15.0-website_sale_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_secondary_unit/it/
carlos-lopez-tecnativa
force-pushed
the
17.0-mig-website_sale_secondary_unit
branch
2 times, most recently
from
a7b529a to
a306615
Compare
CarlosRoca13
suggested changes
Jan 10, 2025
There was a problem hiding this comment.
Thanks for the work 😄
When trying to remove a line of the cart with secondary units I'm getting next error, can you take a look?
Traceback (most recent call last):
File "/opt/odoo/odoo/http.py", line 1783, in _serve_db
return service_model.retrying(self._serve_ir_http, self.env)
File "/opt/odoo/odoo/service/model.py", line 133, in retrying
result = func()
File "/opt/odoo/odoo/http.py", line 1810, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "/opt/odoo/odoo/http.py", line 2014, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "/opt/odoo/addons/website/models/ir_http.py", line 235, in _dispatch
response = super()._dispatch(endpoint)
File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 221, in _dispatch
result = endpoint(**request.params)
File "/opt/odoo/odoo/http.py", line 757, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "/mnt/data/odoo-addons-dir/website_sale_secondary_unit/controllers/main.py", line 34, in cart_update_json
return super().cart_update_json(
File "/opt/odoo/odoo/http.py", line 757, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "/opt/odoo/addons/website_sale/controllers/main.py", line 899, in cart_update_json
values['notification_info'] = self._get_cart_notification_information(order, [values['line_id']])
File "/mnt/data/odoo-addons-dir/website_sale_secondary_unit/controllers/main.py", line 52, in _get_cart_notification_information
for line in res["lines"]:
KeyError: 'lines'
The above server error caused the following client error:
RPC_ERROR: Odoo Server Error
RPC_ERROR
at makeErrorFromResponse (http://oca-e-commerce-17-0-pr1003-a3066151f1fd.runboat.odoo-community.org/web/assets/1/4e5c03a/web.assets_frontend_lazy.min.js:4720:163)
at XMLHttpRequest.<anonymous> (http://oca-e-commerce-17-0-pr1003-a3066151f1fd.runboat.odoo-community.org/web/assets/1/4e5c03a/web.assets_frontend_lazy.min.js:4724:13)
a306615 to
e78f349
Compare
Solved, please try again |
carlos-lopez-tecnativa
force-pushed
the
17.0-mig-website_sale_secondary_unit
branch
from
e78f349 to
c905ee2
Compare
|
@pilarvargas-tecnativa I have applied your suggestion. Could you please update your review? Thanks! |
pilarvargas-tecnativa
approved these changes
Jan 13, 2025
- Replaced the popover implementation with notifications, following the update in odoo/odoo#133990. - Removed the Unit from the displayed price. Previously, Odoo showed the price per unit, making it appropriate to include the UoM. However, as it now displays the total, the UoM is unnecessary.
carlos-lopez-tecnativa
force-pushed
the
17.0-mig-website_sale_secondary_unit
branch
from
c905ee2 to
09b889c
Compare
|
/ocabot migration website_sale_secondary_unit |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at e729ba0. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TT52395
@Tecnativa @pedrobaeza @sergio-teruel @pilarvargas-tecnativa @chienandalu @CarlosRoca13 could you please review this