[14.0][MIG] website_sale_require_login: Migration to 14.0 #866
Conversation
Example of module which requires such refactoring: https://github.com/it-projects-llc/website-addons/tree/10.0/website_sale_checkout_store [FIX] condition to show normal checkout button was wrong in website_sale_suggest_create_account I was equal to (user_authenticated or not signup_allowed and can_checkout) while it has to be (user_authenticated or not signup_allowed) and can_checkout
This test was expecting sign up to be disabled because `auth_signup` is not in its module graph, but since that addon is autoinstallable, it could be installed without our knowledge. Just make sure signup is disabled before running the public user test, to make it unitary. Also, moved to at-install mode, since the post-install one adds no value.
|
Think pre-commit error is not related to me ? can anyone explain what can I do ? |
|
@Tardo @pedrobaeza can you help me to review this ? |
|
For pre-commit, #864 should be finished. For the tests of this PR, check what is the problem. |
Don't undestand ui js test .. when I try manually, it work, think I should find if the selector is correct .. |
|
Look at 15.0 to see the changes done there if they are applicable here. |
njeudy
force-pushed
the
14.0-mig-website_sale_require_login
branch
from
aff7e3a to
b0935d5
Compare
|
Hello @njeudy , are you willing to continue this PR? I also have interest on migrating this module |
njeudy
force-pushed
the
14.0-mig-website_sale_require_login
branch
from
b0935d5 to
117ec8c
Compare
|
I think this PR is ready now, just force push to restart all action. @pedrobaeza is it correct for you ? |
|
Although your commit messages are not correct (and they should be both in one), let's merge it being something relatively old: /ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at dd45473. Thanks a lot for contributing to OCA. ❤️ |
#464 seems to be closed, but need this module.
Don't now if it's a good way to propose again this PR ..