Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0] [MIG] fieldservice_stock #671

Closed
wants to merge 138 commits into from
Closed

Conversation

RLeeOSI
Copy link
Contributor

@RLeeOSI RLeeOSI commented Nov 18, 2020

Migration of fieldservice_stock to 13.0

#354

Moved from #651

.flake8 Outdated
@@ -1,5 +1,5 @@
[flake8]
max-line-length = 88
max-line-length = 80
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should stay at 88

class FSMTerritory(models.Model):
_inherit = "fsm.territory"
class ResTerritory(models.Model):
_inherit = "res.territory"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss the migration scripts for this

@max3903 max3903 added this to the 13.0 milestone Dec 14, 2020
@brian10048 brian10048 linked an issue Jan 16, 2021 that may be closed by this pull request
43 tasks
@brian10048 brian10048 mentioned this pull request Mar 17, 2021
43 tasks
"depends": [
"fieldservice",
"stock_request_direction",
"stock_request_picking_type",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrickrwilson
Copy link
Contributor

@RLeeOSI In v12, PR #675 simplified the fieldservice_stock module. I think we should migrate based on the simplified version since these are still in progress and haven't been merged yet.

@brian10048
Copy link
Contributor

@RLeeOSI let me know if you do not have time to do the migration based on changes in #675 and I'll be glad to work on it

@RLeeOSI
Copy link
Contributor Author

RLeeOSI commented May 25, 2021

@brian10048 Since I'm not familiar with the split into fieldservice_stock and fieldservice_equipment_stock/fieldservice_stock_request, I would appreciate if you could handle this. I agree that this solves several issues with dependencies. Let me know if you want any help with migration scripts or unit tests. Are you going to open migration PRs for the new modules?

@brian10048
Copy link
Contributor

Closing as this was replaced with #797
Thank you for the work @RLeeOSI

For the new modules needing migrated, I don't have much time to work on modules related to stock_request. Generally speaking, the code is mostly the same for these new modules, just moved from where it was. A lot of the migration work you did here will apply to the migration of the new modules

@brian10048 brian10048 closed this May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration to version 13.0