-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0] [MIG] fieldservice_stock #671
Conversation
Travis errors
Travis error
* [ADD] field service stock 0.0.2
…into 13.0-mig-fsm-stock # Conflicts: # fieldservice_stock/models/stock_move.py
c1044a7
to
f3f5ada
Compare
.flake8
Outdated
@@ -1,5 +1,5 @@ | |||
[flake8] | |||
max-line-length = 88 | |||
max-line-length = 80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should stay at 88
class FSMTerritory(models.Model): | ||
_inherit = "fsm.territory" | ||
class ResTerritory(models.Model): | ||
_inherit = "res.territory" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I miss the migration scripts for this
…d-service into 13.0-mig-fsm-stock
"depends": [ | ||
"fieldservice", | ||
"stock_request_direction", | ||
"stock_request_picking_type", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing stock_request_submit in order to do https://github.com/OCA/field-service/pull/671/files?file-filters%5B%5D=.py#diff-f7551e26fc5881da48b15fe64ef2878a3d37ea4fae84aeaa5468416742861325R73
@brian10048 Since I'm not familiar with the split into fieldservice_stock and fieldservice_equipment_stock/fieldservice_stock_request, I would appreciate if you could handle this. I agree that this solves several issues with dependencies. Let me know if you want any help with migration scripts or unit tests. Are you going to open migration PRs for the new modules? |
Closing as this was replaced with #797 For the new modules needing migrated, I don't have much time to work on modules related to stock_request. Generally speaking, the code is mostly the same for these new modules, just moved from where it was. A lot of the migration work you did here will apply to the migration of the new modules |
Migration of fieldservice_stock to 13.0
#354
Moved from #651