Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG]Migrated fieldservice_skill from v13 to v14 #745

Merged
merged 36 commits into from
Apr 23, 2021

Conversation

Freni-OSI
Copy link
Contributor

Migrated fieldservice_skill from v13 to v14

Copy link

@fshah-initos fshah-initos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and Functional tests done. LGTM

@Freni-OSI Freni-OSI mentioned this pull request Apr 13, 2021
43 tasks
@Freni-OSI Freni-OSI force-pushed the 14_mig_fieldservice_skill branch from 7b0c0af to 30480b8 Compare April 14, 2021 09:32
osi-scampbell and others added 27 commits April 14, 2021 15:09
* [IMP] Connect fsm.skill to fsm.template
minor UI improvements
Currently translated at 48.0% (12 of 25 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_skill
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_skill/de/
Currently translated at 100.0% (25 of 25 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_skill
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_skill/de/
Currently translated at 88.0% (22 of 25 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_skill
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_skill/es_CL/
Currently translated at 100.0% (25 of 25 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_skill
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_skill/pt_BR/
Currently translated at 100.0% (25 of 25 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_skill
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_skill/pt_BR/
brian10048 and others added 5 commits April 14, 2021 15:09
Adapted FSM Person Skills to mimic Odoo v13 behavior of Employee Skills.
- Skill progress level instead of priority
- Updated views on FSM Person form
@Freni-OSI Freni-OSI force-pushed the 14_mig_fieldservice_skill branch from 30480b8 to 46e00b5 Compare April 14, 2021 09:39
oca-transbot and others added 2 commits April 14, 2021 15:27
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-13.0/field-service-13.0-fieldservice_skill
Translate-URL: https://translation.odoo-community.org/projects/field-service-13-0/field-service-13-0-fieldservice_skill/
@Freni-OSI Freni-OSI force-pushed the 14_mig_fieldservice_skill branch from 46e00b5 to 63d261d Compare April 14, 2021 09:59
@brian10048 brian10048 added this to the 14.0 milestone Apr 21, 2021
@brian10048 brian10048 linked an issue Apr 21, 2021 that may be closed by this pull request
43 tasks
Copy link
Member

@bodedra bodedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review. LG 👍

Minor feature improvements point:

  • Create a FSM order and assign to any skill level worker.
  • Next, set "Required Skill", it should wipe out current worker if he/she doesn't match with it.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hparfr
Copy link
Contributor

hparfr commented Apr 23, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-745-by-hparfr-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5e4a934 into OCA:14.0 Apr 23, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ee473bd. Thanks a lot for contributing to OCA. ❤️

@bodedra bodedra deleted the 14_mig_fieldservice_skill branch May 13, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration to version 14.0