[14.0][add] fieldservice_contract #809
Conversation
| """ | ||
| for line in self: | ||
| # create order | ||
| if line.product_id.field_service_tracking == "order": |
There was a problem hiding this comment.
Field_service_tracking has not "order" value https://github.com/OCA/field-service/blob/14.0/fieldservice_sale/models/product_template.py#L17. We have "sale" and "line" value which mean that we can create an unique FSM order by sale order if Field_service_tracking = "sale" or one SFM Order by sale line if Field_service_tracking = "line".
It seam that for recurring order we can only create one FSM recurring order by sale line.
paradoxxxzero
force-pushed
the
14.0-fieldservice-contract
branch
from
f040203 to
29b9f5b
Compare
| "fieldservice_recurring", | ||
| "fieldservice_sale_recurring", | ||
| "fieldservice_sale_frequency", | ||
| "fieldservice_recurring_quick_edit", |
There was a problem hiding this comment.
I could not find any PR to this module fieldservice_recurring_quick_edit on version 14.0, does this dependency is required ? or could you point give me the link that I could give a review?
There was a problem hiding this comment.
There was a problem hiding this comment.
The dependency tree should be clarified / refactored.
First, we need frequencies set probably in his own module. Then defined in sale order lines, contracts lines.
Frequency set has two notions;
-
- abstract frequency set ( ambigus defined during the sale. Like "once a month".
-
- concret frequency set, usually derived from the abstract. Like "first monday of each month at 6am".
fsm_recurring_quick_edit let you input an abstract frequency seton thesale order lineand convert it to aconcret frequency seton arecurring order`.
The abstract frequency set may be also used on the contract line.
| self, contract, predecessor_contract_line_id=False | ||
| ): | ||
| self.ensure_one() | ||
| contract.fsm_location_id = self.order_id.fsm_location_id |
There was a problem hiding this comment.
this is a little trap, as developer I won't expect the contract to be updated while preparing conctract liste, also it make hard to overload in submodules
…n creating a recurring order (#15)
… on contract by ._get_invoiceable_stage method
in the sale view
…ed by contract_invoice_start_end_dates
…ined in other view)
if self.env.user.tz is None then UTC
mourad-ehm
force-pushed
the
14.0-fieldservice-contract
branch
from
637ef02 to
c76e4f6
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Blocked by fieldservice_recurring
#762#859Blocked by fieldservice_quick_edit not published in pr yet: https://github.com/akretion/field-service/tree/14.0-mig-fieldservice_recurring_quick_edit