[17.0][MIG] fleet_vehicle_service_services: Migration to 17.0 #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (2 of 2 strings) Translation: fleet-15.0/fleet-15.0-fleet_vehicle_service_services Translate-URL: https://translation.odoo-community.org/projects/fleet-15-0/fleet-15-0-fleet_vehicle_service_services/it/
Currently translated at 100.0% (2 of 2 strings) Translation: fleet-16.0/fleet-16.0-fleet_vehicle_service_services Translate-URL: https://translation.odoo-community.org/projects/fleet-16-0/fleet-16-0-fleet_vehicle_service_services/it/
Currently translated at 100.0% (2 of 2 strings) Translation: fleet-16.0/fleet-16.0-fleet_vehicle_service_services Translate-URL: https://translation.odoo-community.org/projects/fleet-16-0/fleet-16-0-fleet_vehicle_service_services/es/
Currently translated at 100.0% (2 of 2 strings) Translation: fleet-16.0/fleet-16.0-fleet_vehicle_service_services Translate-URL: https://translation.odoo-community.org/projects/fleet-16-0/fleet-16-0-fleet_vehicle_service_services/sv/
Currently translated at 100.0% (2 of 2 strings) Translation: fleet-16.0/fleet-16.0-fleet_vehicle_service_services Translate-URL: https://translation.odoo-community.org/projects/fleet-16-0/fleet-16-0-fleet_vehicle_service_services/pt_BR/
ivantodorovich
requested changes
Dec 31, 2024
There was a problem hiding this comment.
Thanks for the effort in increasing this module robustness.
However, I think these tests aren't useful.
We don't need to write unit tests for every field we add to a model. We can trust the ORM to do its job there, and it's already widely tested by Odoo itself.
IMO we should remove this file
There was a problem hiding this comment.
@ivantodorovich , Thanks for the suggestions.it's fixed.
|
/ocabot migration fleet_vehicle_service_services |
HeliconiaSolutions
force-pushed
the
17.0-mig-fleet_vehicle_service_services
branch
2 times, most recently
from
72c4499 to
cc8905b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.