[17.0][MIG] base_geoengine: Migration to 17.0 #368

peluko00 · 2024-04-25T13:59:45Z

Module migrated to version 17.0

cc https://github.com/APSL 154489
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review

[Issue] Migration to version 17.0 #349

To do:

As an admin, if I change the domain of a layer with the filter button then the change are persisted in database.
As a user, if I change the domain of a layer with the filter button then the change are not persisted in database. There are just the changes in the display.
As an admin,If the geoengine view is in edit mode, I can create new records by drawing them in the view.

…assify

…es as possible

…isplay values of selection field instead of technical value in info map box in geoengine view

The feature to set a symbol with symbol_url or symbol_binary on vector layers was broken. This replace those fields by a new object vector symbol on which you can specify which symbol to use depending on a field value.

geo_contains calls St_Contains SQL search. Plus fix search to set SRID to avoid mixin srid issue.

And extract Swisstopo to move it in a new module

Otherwise partial value is interpreted as context and it will fails on Odoo loading

…lways need to zoom out to get useful informations

OCA-git-bot · 2024-06-29T09:11:04Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2024-06-29T09:11:06Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

mostafabarmshory · 2024-08-31T18:10:41Z

Any update?

@peluko00

peluko00 · 2024-09-20T06:00:41Z

Any update?

@peluko00

I'll continue with this module maybe the next month

mostafabarmshory · 2024-09-25T04:43:43Z

@peluko00

Tx to your commit. Seams everything is ok to merge, is`n it?

peluko00 · 2024-09-25T05:52:30Z

@peluko00

Tx to your commit. Seams everything is ok to merge, is`n it?

Not yet, they are some bugs to solve

mostafabarmshory · 2024-09-25T15:36:01Z

@peluko00

Your last commit fix unit test. So we are ready to merge with the branch.

Is there any bug or issues?

I check it with odoo 17 manually and every thing seams ok.

Let me know if there is any issue, pleas.

BTW, I can help you to finish it,

TX to your work, hope be fine

peluko00 · 2024-09-26T06:46:28Z

@peluko00

Your last commit fix unit test. So we are ready to merge with the branch.

Is there any bug or issues?

I check it with odoo 17 manually and every thing seams ok.

Let me know if there is any issue, pleas.

BTW, I can help you to finish it,

TX to your work, hope be fine

Yes, the bugs are in the TODO description of this PR. If you wanna to solve that make a pr to merge into my branch. Thanks in advance

sersanchus · 2024-09-26T17:33:03Z

base_geoengine/static/src/js/views/geoengine/geoengine_controller/geoengine_controller.esm.js

@@ -40,24 +44,85 @@ export class GeoengineController extends Component {
                offset: offset,
                limit: limit,
                total: count,
-                onUpdate: async ({offset, limit}) => {


There might be a mistake here, the parameter names must be the same that odoo is using: offset and limit. If they don't match the pager can't be updated accordingly.
I could swear this was working when I checked it, has it been changed recently?

Fixed, thanks!

@reichie020212

> > Co-authored-by: Antoni Marroig Campomar <amarroig@apsl.net> Co-authored-by: Red Butay <@reichie020212> Co-authored-by: Miquel Alzanillas <malzanillas@apsl.net> Co-authored-by: Sergio Sancho <sersanchus@gmail.com> "

peluko00 · 2024-09-27T06:25:49Z

@dreispt can you review please

OCA-git-bot · 2024-09-27T06:31:32Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

dreispt · 2024-09-27T09:55:10Z

/ocabot merge nobump

OCA-git-bot · 2024-09-27T09:55:24Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-368-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot · 2024-09-27T09:59:03Z

Congratulations, your PR was merged at dc17fcc. Thanks a lot for contributing to OCA. ❤️

yvaucher and others added 30 commits April 25, 2024 15:54

[MIGR] ensure geoengine view is loaded after container is rendered

a14ba6e

Not pretending we implement limit and offset

baa5353

Fix search returning 0 elements on geo view

2dce09f

Patch mapfish to avoid trying to make more classes than element to cl…

7192190

…assify

Improve patch to classify points to make sure there are as many class…

d7770da

…es as possible

Fix a typo on default key

d62f1e7

Fix tab event listener to display map widget in form view in last tabs

76b34a4

[FIX] display translation of field string instead of field name and d…

fbeb4e2

…isplay values of selection field instead of technical value in info map box in geoengine view

[FIX] base_geoengine - allow to use multiple icons on your maps

b7953ca

The feature to set a symbol with symbol_url or symbol_binary on vector layers was broken. This replace those fields by a new object vector symbol on which you can specify which symbol to use depending on a field value.

Allow to drag pan through polygons

471ff4e

By default use OSM

f174ff5

Fix path of openerp for doc build

bc7ee58

Remove google from selection as it is currently broken

b0da64b

Add geo_contains operator to geo_search method.

e84bb8a

geo_contains calls St_Contains SQL search. Plus fix search to set SRID to avoid mixin srid issue.

Refactor WMTS to be able to add a generic config

017b751

And extract Swisstopo to move it in a new module

Add a button on map widget to clear geometry from the map

6edebeb

Fix _setup_fields signature due to OCA/OCB@87d160a

8ae13c0

Otherwise partial value is interpreted as context and it will fails on Odoo loading

Bump version

2eadab6

Adapt test to mandatory partial attribute in _setup_fields

b7c0cdd

Fix srid value read which was unset in field properties

0629acd

Add parameters to define extends and projection

445ffa7

Adapt tests

b4fabf7

Bump version

5a6444f

Target only the right tab where the map is to add listener.

8ed3867

Ensure we call add_tab_listener only once

4878c3f

Address the right container when drawing the widget map

67ccfca

Fix widget initialized too early in second tab thus having bad size

b634cfb

Fix offset issues on the map by reseting offset when scroll bar is used

e27bee2

Don't zoom when setting or changing a geometry

66fd657

Add an option to set a default zoom to avoid showing a map that you a…

8e75c1a

…lways need to zoom out to get useful informations

mostafabarmshory approved these changes Jun 29, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Jun 29, 2024

peluko00 force-pushed the 17.0-mig-base_geoengine branch from 7311d21 to bc60353 Compare September 20, 2024 06:01

sersanchus suggested changes Sep 26, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Sep 26, 2024

[MIG] base_geoengine: Migration to 17.0

5142637

> > Co-authored-by: Antoni Marroig Campomar <amarroig@apsl.net> Co-authored-by: Red Butay <@reichie020212> Co-authored-by: Miquel Alzanillas <malzanillas@apsl.net> Co-authored-by: Sergio Sancho <sersanchus@gmail.com> "

peluko00 force-pushed the 17.0-mig-base_geoengine branch from bc60353 to 5142637 Compare September 27, 2024 06:09

sersanchus approved these changes Sep 27, 2024

View reviewed changes

OCA-git-bot added the approved label Sep 27, 2024

OCA-git-bot added the ready to merge label Sep 27, 2024

dreispt approved these changes Sep 27, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Sep 27, 2024

OCA-git-bot merged commit d08686f into OCA:17.0 Sep 27, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Sep 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] base_geoengine: Migration to 17.0 #368

[17.0][MIG] base_geoengine: Migration to 17.0 #368

peluko00 commented Apr 25, 2024 •

edited

Loading

OCA-git-bot commented Jun 29, 2024

OCA-git-bot commented Jun 29, 2024

mostafabarmshory commented Aug 31, 2024

peluko00 commented Sep 20, 2024

mostafabarmshory commented Sep 25, 2024

peluko00 commented Sep 25, 2024

mostafabarmshory commented Sep 25, 2024

peluko00 commented Sep 26, 2024

sersanchus Sep 26, 2024

peluko00 Sep 27, 2024

peluko00 commented Sep 27, 2024

OCA-git-bot commented Sep 27, 2024

dreispt commented Sep 27, 2024

OCA-git-bot commented Sep 27, 2024

OCA-git-bot commented Sep 27, 2024

[17.0][MIG] base_geoengine: Migration to 17.0 #368

[17.0][MIG] base_geoengine: Migration to 17.0 #368

Conversation

peluko00 commented Apr 25, 2024 • edited Loading

OCA-git-bot commented Jun 29, 2024

OCA-git-bot commented Jun 29, 2024

mostafabarmshory commented Aug 31, 2024

peluko00 commented Sep 20, 2024

mostafabarmshory commented Sep 25, 2024

peluko00 commented Sep 25, 2024

mostafabarmshory commented Sep 25, 2024

peluko00 commented Sep 26, 2024

sersanchus Sep 26, 2024

Choose a reason for hiding this comment

peluko00 Sep 27, 2024

Choose a reason for hiding this comment

peluko00 commented Sep 27, 2024

OCA-git-bot commented Sep 27, 2024

dreispt commented Sep 27, 2024

OCA-git-bot commented Sep 27, 2024

OCA-git-bot commented Sep 27, 2024

peluko00 commented Apr 25, 2024 •

edited

Loading