Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][Feature] add website_geoengine_store_locator #376

Merged
merged 1 commit into from
Oct 30, 2024
Merged

[16.0][Feature] add website_geoengine_store_locator #376

merged 1 commit into from
Oct 30, 2024

Conversation

wouitmil
Copy link

@wouitmil wouitmil commented Jul 4, 2024

This module extends the website_geoengine odoo module, to add a map snippet view for the website.
By default the map features are filtered to only display contact of type store.

@wouitmil wouitmil force-pushed the camptocamp-publish-oca branch 2 times, most recently from 4952bde to f4aed1a Compare July 4, 2024 12:30
@wouitmil wouitmil force-pushed the camptocamp-publish-oca branch from f4aed1a to 20da76a Compare August 22, 2024 06:28
@wouitmil wouitmil force-pushed the camptocamp-publish-oca branch from 20da76a to 76119c5 Compare August 29, 2024 12:45
@yvaucher
Copy link
Member

Please fix the pre-commit and squash some of those commits (Most likely in one as the feature is adding a new module)

@sbrunner sbrunner force-pushed the camptocamp-publish-oca branch from 4bcf9b7 to d14399c Compare October 30, 2024 07:52
@wouitmil wouitmil force-pushed the camptocamp-publish-oca branch from 4cd7c66 to 6ecf4d2 Compare October 30, 2024 10:59
@wouitmil
Copy link
Author

Please fix the pre-commit and squash some of those commits (Most likely in one as the feature is adding a new module)

@wouitmil
Copy link
Author

wouitmil commented Oct 30, 2024 •
edited
Loading

Hello @yvaucher pre-commit fixed and commits squashed

@wouitmil wouitmil force-pushed the camptocamp-publish-oca branch from 6ecf4d2 to d220df7 Compare October 30, 2024 11:12
yvaucher
yvaucher requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Only a couple of issue on files.
Some python files misses a copyright header + readme are missing the contributors because of a typo in some of the file names

website_geoengine/models/res_partner.py
@@ -0,0 +1,117 @@
from odoo import _, api, fields, models
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a license header

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I then also added license informations in the JS files

website_geoengine/readme/CONTIBUTORS.rst Outdated
@@ -0,0 +1,2 @@
* Stéphane Brunner <stephane.brunner@camptocamp.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in this file name, that's why you don't appear in the readme file as contributor.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected !

website_geoengine_store_locator/readme/CONTIBUTORS.rst Outdated
@@ -0,0 +1,2 @@
* Stéphane Brunner <stephane.brunner@camptocamp.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typo on the file name. (missing an R)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected

@wouitmil wouitmil force-pushed the camptocamp-publish-oca branch from d220df7 to e277c99 Compare October 30, 2024 16:18
@yvaucher
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-376-by-yvaucher-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f7a5bb1 into OCA:16.0 Oct 30, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 66c2542. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvaucher yvaucher yvaucher approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wouitmil @yvaucher @OCA-git-bot