-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD]document_url_google_drive #444
[16.0][ADD]document_url_google_drive #444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional LGTM
NB: I had to deploy this module on my own server because runboat doesn't support https
@pedrobaeza @OpenCode would appreciate your review) We have some more features coming based on this module |
This is difficult to be tested, as we don't have a Google API key, but theoretically seems OK. |
@pedrobaeza Yup, I understand this. Thank you anyway! I think we might need to find some solution in the future. Because we would like to contribute some other Google (and not only Google) related modules in the future. |
@@ -0,0 +1,3 @@ | |||
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing: # Copyright (C) 2023 Cetmix OÜ
@@ -0,0 +1,3 @@ | |||
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
@@ -0,0 +1,3 @@ | |||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
"document_url_google_drive/static/src/js/attachment_google_picker.esm.js", | ||
"document_url_google_drive/static/src/xml/google_picker_url.xml", | ||
"document_url_google_drive/static/src/xml/attachment_google_picker.xml", | ||
"document_url_google_drive/static/src/js/attachment_card.esm.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File does not exist. Please double-check.
66ba25d
to
d806fdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional LGTM
Hi @pedrobaeza looks like tests have fallen here due to some GitHub Issues. What is the right way to re-launch them? |
You have to wait a bit to relaunch: |
@pedrobaeza looks like this is solved now. However I don't have enough rights to re-launch the tests. Could you do this please? Or give me a clue how this can be solved another way. Thank you in advance! |
Relaunched. A way to force the relaunch is to rebase locally / commit ammend, and forced pushing. |
Noted. Thank you! |
This PR has the |
#. Open the form view of an object (Example: Customer Invoice INV/2019/0007). #. Go to | ||
the chatter and click on the attached icon. #. Click **Add GDrive link**. #. Fill the | ||
wizard fields and click on Add button. #. In the open window, select the files you need | ||
and press the select button. #. You will see a new **URL attachment** in the set of | ||
attachments related to the object. #. In order to log in under another google user, | ||
click on the logout icon located after **Add GDrive link** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please fix the line breaks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @yostashiro thank you for your feedback! How exactly should they be fixed? Could you please add a suggestion so that we could accept it
2d3ac0a
to
40dbe9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional Review: LGTM
43e3b4e
to
d0951e8
Compare
d0951e8
to
a6458b3
Compare
a6458b3
to
ea29d68
Compare
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 99b6c9b. Thanks a lot for contributing to OCA. ❤️ |
Thank you @pedrobaeza and everyone involved! |
This module allows to select and attach documents directly from the Google drive.
Selected documents will be attached as links.