Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD]document_url_google_drive #444

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

DemchukM
Copy link
Contributor

@DemchukM DemchukM commented Nov 9, 2023

This module allows to select and attach documents directly from the Google drive.
Selected documents will be attached as links.

Copy link
Member

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional LGTM

NB: I had to deploy this module on my own server because runboat doesn't support https

@ivs-cetmix
Copy link
Member

@pedrobaeza @OpenCode would appreciate your review) We have some more features coming based on this module

@pedrobaeza pedrobaeza added this to the 16.0 milestone Nov 10, 2023
@pedrobaeza
Copy link
Member

This is difficult to be tested, as we don't have a Google API key, but theoretically seems OK.

@ivs-cetmix
Copy link
Member

This is difficult to be tested, as we don't have a Google API key, but theoretically seems OK.

@pedrobaeza Yup, I understand this. Thank you anyway! I think we might need to find some solution in the future. Because we would like to contribute some other Google (and not only Google) related modules in the future.
This is also related to the https://github.com/OCA/storage repo.

@@ -0,0 +1,3 @@
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing: # Copyright (C) 2023 Cetmix OÜ

@@ -0,0 +1,3 @@
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@@ -0,0 +1,3 @@
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

"document_url_google_drive/static/src/js/attachment_google_picker.esm.js",
"document_url_google_drive/static/src/xml/google_picker_url.xml",
"document_url_google_drive/static/src/xml/attachment_google_picker.xml",
"document_url_google_drive/static/src/js/attachment_card.esm.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File does not exist. Please double-check.

@DemchukM DemchukM force-pushed the 16.0-t3012-document_url_google_drive branch from 66ba25d to d806fdb Compare November 16, 2023 13:09
Copy link

@Aldeigja Aldeigja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional LGTM

@ivs-cetmix
Copy link
Member

Hi @pedrobaeza looks like tests have fallen here due to some GitHub Issues. What is the right way to re-launch them?

@pedrobaeza
Copy link
Member

You have to wait a bit to relaunch:

https://x.com/gurneyalex/status/1725121761933422628?s=20

@ivs-cetmix
Copy link
Member

You have to wait a bit to relaunch:

https://x.com/gurneyalex/status/1725121761933422628?s=20

@pedrobaeza looks like this is solved now. However I don't have enough rights to re-launch the tests. Could you do this please? Or give me a clue how this can be solved another way. Thank you in advance!

@pedrobaeza
Copy link
Member

Relaunched. A way to force the relaunch is to rebase locally / commit ammend, and forced pushing.

@ivs-cetmix
Copy link
Member

Relaunched. A way to force the relaunch is to rebase locally / commit ammend, and forced pushing.

Noted. Thank you!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Comment on lines 3 to 8
#. Open the form view of an object (Example: Customer Invoice INV/2019/0007). #. Go to
the chatter and click on the attached icon. #. Click **Add GDrive link**. #. Fill the
wizard fields and click on Add button. #. In the open window, select the files you need
and press the select button. #. You will see a new **URL attachment** in the set of
attachments related to the object. #. In order to log in under another google user,
click on the logout icon located after **Add GDrive link**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the line breaks?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @yostashiro thank you for your feedback! How exactly should they be fixed? Could you please add a suggestion so that we could accept it

@ivs-cetmix ivs-cetmix force-pushed the 16.0-t3012-document_url_google_drive branch from 2d3ac0a to 40dbe9f Compare November 18, 2023 14:53
Copy link

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review: LGTM

@ivs-cetmix ivs-cetmix force-pushed the 16.0-t3012-document_url_google_drive branch from d0951e8 to a6458b3 Compare February 6, 2024 11:05
@ivs-cetmix ivs-cetmix force-pushed the 16.0-t3012-document_url_google_drive branch from a6458b3 to ea29d68 Compare February 6, 2024 11:19
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-444-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d7a308f into OCA:16.0 Feb 6, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 99b6c9b. Thanks a lot for contributing to OCA. ❤️

@ivs-cetmix ivs-cetmix deleted the 16.0-t3012-document_url_google_drive branch February 6, 2024 11:33
@ivs-cetmix
Copy link
Member

Thank you @pedrobaeza and everyone involved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants