-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
16.0[IMP]document_page: menu_parent_id context domain of menu creation #448
16.0[IMP]document_page: menu_parent_id context domain of menu creation #448
Conversation
I will put this PR in draft for some time because i am developing a unit test Thank you for your review! |
1e1ddf1
to
ab335a1
Compare
ab335a1
to
1897d3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
/ocabot merge patch |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 954d7b2. Thanks a lot for contributing to OCA. ❤️ |
On the document_page module, there is one use case when we can't correctly create a menu item for a page.
This case occurs when we want to create the document menu under a new "Documentation" menu. Example:
Sales
- Documentation
- Page 1
- Page 2
...
Steps to reproduce:
The reason of the problem is that, by default, we only can see the menus that have an action, or a child with actions.
To see all, odoo gives a context parameter that can be placed on the field: context="{'ir.ui.menu.full_list': True}".
However, with this context on the menu_parent_id of the document_page create menu wizard the document users are able to see menus they must not be able to see due to permission groups; and they can create aditional menus under the unauthorized ones.
To solve this, a new context parameter has been created: "ir.ui.menu.authorized_list", that allows to see all menus, except the unauthorized by permission groups
PD: A unit test is in progress