Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX]document_url #460

Merged
merged 1 commit into from
Feb 18, 2024
Merged

[16.0][FIX]document_url #460

merged 1 commit into from
Feb 18, 2024

Conversation

DemchukM
Copy link
Contributor

Fixed not working properly when "web_responsive" is installed

@pedrobaeza pedrobaeza added this to the 16.0 milestone Feb 14, 2024
pedrobaeza
pedrobaeza approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new method works. From runboat, I can't test the compatibility with web_responsive.

chienandalu
chienandalu approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍

document_url/static/src/js/url.esm.js
Comment on lines +35 to +37
/**
* Handles click on the attach button.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: maybe it'd be more informative to explain why we need to handle the click on the attach button.

@ivs-cetmix
Copy link
Member

Closes OCA/web#2741

ivs-cetmix
ivs-cetmix approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-460-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command git push origin 16.0-ocabot-merge-pr-460-by-pedrobaeza-bump-patch:16.0 failed with output:

To https://github.com/OCA/knowledge
 ! [remote rejected]   16.0-ocabot-merge-pr-460-by-pedrobaeza-bump-patch -> 16.0 (cannot lock ref 'refs/heads/16.0': is at 81b6f14d104a7d30b15bb92140bc12e990103667 but expected cf04e15ee764193df15b66ac78c95690567cc330)
error: failed to push some refs to 'https://***@github.com/OCA/knowledge'

@OCA-git-bot OCA-git-bot merged commit ce2fcbf into OCA:16.0 Feb 18, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 81b6f14. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@chienandalu chienandalu chienandalu approved these changes

@ivs-cetmix ivs-cetmix ivs-cetmix approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@DemchukM @ivs-cetmix @OCA-git-bot @pedrobaeza @chienandalu