Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] l10n_us_partner_legal_number #136

Merged
merged 6 commits into from
Nov 29, 2024
Merged

[17.0][MIG] l10n_us_partner_legal_number #136

merged 6 commits into from
Nov 29, 2024

Conversation

JordiMForgeFlow
Copy link

No description provided.

AaronHForgeFlow
AaronHForgeFlow approved these changes Nov 21, 2024
View reviewed changes
Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

@JordiMForgeFlow
Copy link
Author

Hi @max3903

Could we get a review and merge this one? It is generating the requirements.txt file and it creates conflicts with other PRs that are also doing the same for V17 like #137

@Abimael1321
Copy link

Functionally reviewed. LGTM!
I know that in previous versions it is not implemented, but as a suggestion, I would add some kind of notification if the legal ID number is the same in more than one contact, as is the case with the Tax ID.

@JordiMForgeFlow
Copy link
Author

@OCA/local-usa-maintainers could we get a merge here? :)

@max3903 max3903 added this to the 17.0 milestone Nov 29, 2024
@max3903 max3903 self-assigned this Nov 29, 2024
@max3903
Copy link
Member

max3903 commented Nov 29, 2024

/ocabot migration l10n_us_partner_legal_number

@OCA-git-bot OCA-git-bot mentioned this pull request Nov 29, 2024
Open
4 tasks
@max3903
Copy link
Member

max3903 commented Nov 29, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-136-by-max3903-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit dcfe638 into OCA:17.0 Nov 29, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d1cff60. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 17.0-mig-l10n_us_partner_legal_number branch November 29, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abimael1321 Abimael1321 Abimael1321 approved these changes

@JoanSForgeFlow JoanSForgeFlow JoanSForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@JordiBForgeFlow JordiBForgeFlow JordiBForgeFlow approved these changes

Assignees

@max3903 max3903

Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
9 participants
@JordiMForgeFlow @Abimael1321 @max3903 @OCA-git-bot @JordiBForgeFlow @AaronHForgeFlow @MiquelRForgeFlow @JoanSForgeFlow @lk-eska