Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] maintenance_equipment_sequence: add model_create_multi to create method #435

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

is-ife
Copy link

@is-ife is-ife commented Nov 4, 2024

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @AdriaGForgeFlow,
some modules you are maintaining are being modified, check this out!

@rf-ife rf-ife force-pushed the 2376-16.0-maintenance_equipment_sequence branch from 027be25 to 6b65c3a Compare November 28, 2024 16:12
@@ -19,6 +19,24 @@ def test_01_maintenance_equipment_sequence(self):
sequence number has been set
"""
# Create category
seq_0 = self.sequence_obj.create(
Copy link

@ng-ife ng-ife Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rf-ife Please move this to test_02_maintenance_equipment_sequence()

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@rf-ife rf-ife force-pushed the 2376-16.0-maintenance_equipment_sequence branch from af507a9 to bcc9767 Compare November 29, 2024 18:16
@ng-ife
Copy link

ng-ife commented Dec 11, 2024

Hello @pedrobaeza
Can you have a look at this PR?
Thank you

@pedrobaeza
Copy link
Member

@ng-ife ng-ife force-pushed the 2376-16.0-maintenance_equipment_sequence branch from bcc9767 to e1a117b Compare December 19, 2024 09:37
@is-ife is-ife changed the title [imp] add model_create_multi to create method [fix] add model_create_multi to create method Dec 19, 2024
@is-ife is-ife changed the title [fix] add model_create_multi to create method [16] [FIX] add model_create_multi to create method Dec 19, 2024
@is-ife is-ife changed the title [16] [FIX] add model_create_multi to create method [16.0] [FIX add model_create_multi to create method Dec 19, 2024
@is-ife is-ife changed the title [16.0] [FIX add model_create_multi to create method [16.0] [FIX] add model_create_multi to create method Dec 19, 2024
@ng-ife
Copy link

ng-ife commented Dec 19, 2024

@pedrobaeza Should be fine now. Thanks for the comment.

@pedrobaeza pedrobaeza changed the title [16.0] [FIX] add model_create_multi to create method [16.0][FIX] maintenance_equipment_sequence: add model_create_multi to create method Dec 19, 2024
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

…on newly created record(s)

Co-authored-by: Pedro M. Baeza <pedro.baeza@tecnativa.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants