Skip to content

Commit

Permalink
[ADD] partner_country_state_required
Browse files Browse the repository at this point in the history
  • Loading branch information
OriolMForgeFlow committed Oct 17, 2023
1 parent 3211bf9 commit 7c0d0c1
Show file tree
Hide file tree
Showing 11 changed files with 188 additions and 0 deletions.
80 changes: 80 additions & 0 deletions partner_country_state_required/README.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
==============================
Partner Country State Required
==============================

..
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:1e663abc24a3fe67cd3201724c9557a49243c69cde035d79c97d641a274d2502
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
:target: https://odoo-community.org/page/development-status
:alt: Beta
.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fpartner--contact-lightgray.png?logo=github
:target: https://github.com/OCA/partner-contact/tree/16.0/partner_company_default
:alt: OCA/partner-contact
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
:target: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_company_default
:alt: Translate me on Weblate
.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
:target: https://runboat.odoo-community.org/builds?repo=OCA/partner-contact&target_branch=16.0
:alt: Try me on Runboat

|badge1| |badge2| |badge3| |badge4| |badge5|

This module assigns default company to res.parnter.

Background
~~~~~~~~~~

Up to 12.0, Odoo used to assign a company by default when partner was added,
however the default company proposal has been removed since 13.0 with multi-company refactoring.
This causes inconveniences to users who want to seggregate partner records between companies.

ref. https://github.com/odoo/odoo/commit/25714692b23624d04a43862db26ebcf802b89399

**Table of contents**

.. contents::
:local:

Bug Tracker
===========

Bugs are tracked on `GitHub Issues <https://github.com/OCA/partner-contact/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
`feedback <https://github.com/OCA/partner-contact/issues/new?body=module:%20partner_company_default%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.

Do not contact contributors directly about support or help with technical issues.

Credits
=======

Authors
~~~~~~~

* Quartile Limited

Maintainers
~~~~~~~~~~~

This module is maintained by the OCA.

.. image:: https://odoo-community.org/logo.png
:alt: Odoo Community Association
:target: https://odoo-community.org

OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.

This module is part of the `OCA/partner-contact <https://github.com/OCA/partner-contact/tree/16.0/partner_company_default>`_ project on GitHub.

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
1 change: 1 addition & 0 deletions partner_country_state_required/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from . import models
11 changes: 11 additions & 0 deletions partner_country_state_required/__manifest__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Copyright 2023 ForgeFlow
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
{
"name": "Partner Country State Required",
"version": "16.0.1.0.0",
"author": "ForgeFlow, Odoo Community Association (OCA)",
"website": "https://github.com/OCA/partner-contact",
"depends": ["base"],
"license": "AGPL-3",
"installable": True,
}
1 change: 1 addition & 0 deletions partner_country_state_required/models/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from . import res_partner
27 changes: 27 additions & 0 deletions partner_country_state_required/models/res_partner.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Copyright 2023 ForgeFlow
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

from odoo import _, api, models
from odoo.exceptions import ValidationError


class ResPartner(models.Model):
_inherit = "res.partner"

@api.constrains("country_id", "state_id")
def _check_state_required(self):
if self.env.context.get("no_state_required"):
return

for record in self:
if (
record.country_id
and record.country_id.state_ids
and not record.state_id
):
raise ValidationError(
_(
"Please specify a state for the address when selecting "
"a country with available states."
)
)
1 change: 1 addition & 0 deletions partner_country_state_required/readme/CONTRIBUTORS.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* Oriol Miranda <oriol.miranda@forgeflow.com>
1 change: 1 addition & 0 deletions partner_country_state_required/readme/DESCRIPTION.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This module forces partners assigned to countries having fed. states should have a state assigned.
1 change: 1 addition & 0 deletions partner_country_state_required/tests/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from . import test_state_required
58 changes: 58 additions & 0 deletions partner_country_state_required/tests/test_state_required.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
# Copyright 2023 ForgeFlow
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

from odoo.exceptions import ValidationError
from odoo.tests.common import TransactionCase


class TestCountryStateRequired(TransactionCase):
@classmethod
def setUpClass(cls):
super(TestCountryStateRequired, cls).setUpClass()
# cls.spain = cls.env["res.country"]
cls.partner_model = cls.env["res.partner"]
cls.spain = cls.env.ref("base.es")
cls.state_bcn = cls.env.ref("base.state_es_b")

def test_create_partner(self):
vals = {
"name": "Test Partner 1",
"country_id": self.spain.id,
}
with self.assertRaisesRegex(
ValidationError,
"Please specify a state for the address when selecting "
"a country with available states.",
):
self.partner_model.create(vals)

vals["state_id"] = self.state_bcn.id
partner = self.partner_model.create(vals)

self.assertTrue(partner)

def test_write_partner(self):
vals = {
"name": "Test Partner 2",
}
partner = self.partner_model.create(vals)

with self.assertRaisesRegex(
ValidationError,
"Please specify a state for the address when selecting "
"a country with available states.",
):
partner.write(
{
"country_id": self.spain.id,
}
)

write_vals = {
"country_id": self.spain.id,
"state_id": self.state_bcn.id,
}

partner.write(write_vals)

self.assertEqual(partner.state_id.code, "B")
6 changes: 6 additions & 0 deletions setup/partner_country_state_required/setup.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import setuptools

setuptools.setup(
setup_requires=['setuptools-odoo'],
odoo_addon=True,
)

0 comments on commit 7c0d0c1

Please sign in to comment.