Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] partner_country_state_required #1582

Merged
merged 2 commits into from
Nov 17, 2023
Merged

[16.0][ADD] partner_country_state_required #1582

merged 2 commits into from
Nov 17, 2023

Conversation

OriolMForgeFlow
Copy link
Contributor

No description provided.

@OriolMForgeFlow OriolMForgeFlow force-pushed the 16.0-add-partner_country_state_required branch 5 times, most recently from f961cb9 to 4203c67 Compare October 18, 2023 06:56
LoisRForgeFlow
LoisRForgeFlow approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review LGTM

Readme seems to be from a different module, but it will be overridden anyway

@OriolMForgeFlow OriolMForgeFlow force-pushed the 16.0-add-partner_country_state_required branch 2 times, most recently from ab48e0f to 30c07f8 Compare October 18, 2023 07:16
JordiMForgeFlow
JordiMForgeFlow approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code + functional review LGTM 👍🏼

SergiCForgeFlow
SergiCForgeFlow approved these changes Oct 18, 2023
View reviewed changes
Copy link

@SergiCForgeFlow SergiCForgeFlow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM 👍

@JordiMForgeFlow JordiMForgeFlow force-pushed the 16.0-add-partner_country_state_required branch from 30c07f8 to 44eb2c8 Compare October 28, 2023 16:19
@JordiMForgeFlow
Copy link
Contributor

I have rebased the PR to resolve conflicts CC @OriolMForgeFlow

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OriolMForgeFlow OriolMForgeFlow force-pushed the 16.0-add-partner_country_state_required branch 5 times, most recently from c2330f4 to eee4aef Compare November 16, 2023 08:58
@OriolMForgeFlow OriolMForgeFlow force-pushed the 16.0-add-partner_country_state_required branch from eee4aef to edf7da1 Compare November 16, 2023 09:25
JordiMForgeFlow
JordiMForgeFlow approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new improvements @OriolMForgeFlow , code + functional review LGTM 👍🏼

@dreispt
Copy link
Member

dreispt commented Nov 17, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1582-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 17, 2023
@OCA-git-bot
Merge PR #1582 into 16.0
6c344f0 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-1582-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7417fbd into OCA:16.0 Nov 17, 2023
8 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4071e61. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 16.0-add-partner_country_state_required branch November 20, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergiCForgeFlow SergiCForgeFlow SergiCForgeFlow approved these changes

@JordiMForgeFlow JordiMForgeFlow JordiMForgeFlow approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@OriolMForgeFlow @JordiMForgeFlow @OCA-git-bot @dreispt @LoisRForgeFlow @SergiCForgeFlow