[16.0][ADD] partner_search_alias #1833
Conversation
AungKoKoLin1997
force-pushed
the
16.0-add-partner_search_alias
branch
from
c055fed to
f97d82d
Compare
There was a problem hiding this comment.
@AungKoKoLin1997 Can you please also extend the partner search view to consider search_alias for the name field?
Please also make it clear in the readme file where in the form view users can find the added field.
| <field name="inherit_id" ref="base.view_partner_tree" /> | ||
| <field name="arch" type="xml"> | ||
| <field name="translated_display_name" position="after"> | ||
| <field name="search_alias" /> |
There was a problem hiding this comment.
| <field name="search_alias" /> | |
| <field name="search_alias" optional="hide" /> |
| <field name="model">res.partner</field> | ||
| <field name="inherit_id" ref="base.view_partner_form" /> | ||
| <field name="arch" type="xml"> | ||
| <field name="vat" position="after"> |
There was a problem hiding this comment.
Let's move the field somewhere less obtrusive.
| <field name="vat" position="after"> | |
| <field name="ref" position="after"> |
There was a problem hiding this comment.
I updated the code.
AungKoKoLin1997
force-pushed
the
16.0-add-partner_search_alias
branch
2 times, most recently
from
fc36289 to
12ef300
Compare
|
Hi community, With my current design, there might be issues if another module also extends |
| @api.model | ||
| def _name_search( | ||
| self, name="", args=None, operator="ilike", limit=100, name_get_uid=None | ||
| ): | ||
| args = list(args or []) | ||
| if name: | ||
| args += ["|", ("search_alias", operator, name)] | ||
| return super()._name_search(name, args, operator, limit, name_get_uid) |
There was a problem hiding this comment.
@AungKoKoLin1997 Please try this.
| @api.model | |
| def _name_search( | |
| self, name="", args=None, operator="ilike", limit=100, name_get_uid=None | |
| ): | |
| args = list(args or []) | |
| if name: | |
| args += ["|", ("search_alias", operator, name)] | |
| return super()._name_search(name, args, operator, limit, name_get_uid) | |
| @property | |
| def _rec_names_search(self): | |
| return list(set(super()._rec_names_search + ["search_alias"])) |
There was a problem hiding this comment.
It works. Thank you.
AungKoKoLin1997
force-pushed
the
16.0-add-partner_search_alias
branch
2 times, most recently
from
36e4083 to
27995fc
Compare
AungKoKoLin1997
force-pushed
the
16.0-add-partner_search_alias
branch
from
27995fc to
ecf3c6a
Compare
| filter_domain = filter_domain.replace( | ||
| "[", "['|', ('search_alias', 'ilike', self), " | ||
| ) |
There was a problem hiding this comment.
Shouldn't we be using expression.OR() instead?
There was a problem hiding this comment.
To use expression.OR(), the XML string must be converted to a Python list using safe_eval. However, safe_eval fails if the string includes unsupported expressions like self. Seem like we have to replace self with some values and I think we can't do it. So, I prefer using current approach. How do you think?
There was a problem hiding this comment.
I think we can leave the code as is on second thought. Thanks for checking.
|
This PR has the |
This module allows users to set non-official names for partners in the search_alias field, improving search usability by enabling searches using alternative names.
@qrtl QT4793