[17.0][FIX] partner_display_name_line_break: Do not split with empty name #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grindtildeath
changed the title
Do not split on two lines if name is empty as it would display the address type on a new line in the report. This happens because Odoo splits the display_name on \n character and discards the first element to get the address from the display_name. In which case, the address type would appear as part of the address. In case this is still needed, an added context key allows to still display the address type.
grindtildeath
force-pushed
the
17.0-fix-line_break_address_type
branch
from
c219a1c to
ec621ad
Compare
This was referenced Oct 29, 2024
ivantodorovich
approved these changes
Oct 29, 2024
ajaniszewska-dev
approved these changes
Oct 29, 2024
|
This PR has the |
rvalyi
approved these changes
Nov 3, 2024
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at d9ec5d0. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not split on two lines if name is empty as it would display the address type on a new line in the report.
This happens because Odoo splits the display_name on \n character and discards the first element to get the address from the display_name. In which case, the address type would appear as part of the address.
In case this is still needed, an added context key allows to still display the address type.