[16.0][MIG] company_default_partner_pricelist #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Odoo standard gives priority to a generic property before using the domain hook to obtain the default pricelist. Therefore, this fix manages the default pricelist in the company by utilizing a generic property.
geomer198
force-pushed
the
16.0-t4218-company_default_partner_pricelist-mig
branch
from
a382afa to
ffbfa74
Compare
hoangtrann
suggested changes
Jan 2, 2025
|
|
||
| @openupgrade.migrate() | ||
| def migrate(env, version): | ||
| company = env["res.company"] |
| @openupgrade.migrate() | ||
| def migrate(env, version): | ||
| company = env["res.company"] | ||
| ir_property = env["ir.property"] |
| company = env["res.company"] | ||
| ir_property = env["ir.property"] | ||
| field = env["ir.model.fields"]._get("res.partner", "property_product_pricelist") | ||
| for record in company.search([]): |
There was a problem hiding this comment.
Suggested change
| for record in company.search([]): | |
| for company in company.search([]): |
hoangtrann
suggested changes
Jan 6, 2025
| class ResCompany(models.Model): | ||
| _inherit = "res.company" | ||
|
|
||
| default_property_product_pricelist = fields.Many2one( |
There was a problem hiding this comment.
Suggested change
| default_property_product_pricelist = fields.Many2one( | |
| default_property_product_pricelist_id = fields.Many2one( |
There was a problem hiding this comment.
it should have a subfix as _id for many2one
| def _update_partner_pricelist_generic_property(self): | ||
| self.ensure_one() | ||
| default_property_pp = self.default_property_product_pricelist | ||
| ir_property = self.env["ir.property"] |
There was a problem hiding this comment.
Suggested change
| ir_property = self.env["ir.property"] | |
| IrProperty = self.env["ir.property"] |
There was a problem hiding this comment.
and maybe set it with sudo() here too since you use sudo for all the following calls
geomer198
force-pushed
the
16.0-t4218-company_default_partner_pricelist-mig
branch
from
d1a1f90 to
d48a280
Compare
hoangtrann
reviewed
Jan 6, 2025
| field = self.env["ir.model.fields"]._get( | ||
| "res.partner", "property_product_pricelist" | ||
| ) | ||
| ppty = ir_property_obj.sudo().search( |
There was a problem hiding this comment.
could you help checking as if you already specify ir_property_obj with sudo, all the sudos on line 22, 33, 35 and 39 are not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to 16.0