-
-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] partner_employee_quantity: Migration to 17.0 #1950
base: 17.0
Are you sure you want to change the base?
[17.0][MIG] partner_employee_quantity: Migration to 17.0 #1950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just a minor change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -10,7 +10,7 @@ | |||
<group | |||
name="employee_quantity" | |||
string="Employee quantity" | |||
attrs="{'invisible': [('is_company', '=', False)]}" | |||
invisible="is_company == False" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better use truthy / falsey coercion. If by any chance is_company
is None
this won't be true, so better be safe to avoid bugs that later ar really hard to find out 😉
invisible="is_company == False" | |
invisible="not is_company" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you have a moment, could you check if I did it correctly? Thanks again!
28eed5e
to
68a48b7
Compare
Currently translated at 100.0% (16 of 16 strings) Translation: partner-contact-8.0/partner-contact-8.0-partner_employee_quantity Translate-URL: https://translation.odoo-community.org/projects/partner-contact-8-0/partner-contact-8-0-partner_employee_quantity/es/
Currently translated at 43.7% (7 of 16 strings) Translation: partner-contact-8.0/partner-contact-8.0-partner_employee_quantity Translate-URL: https://translation.odoo-community.org/projects/partner-contact-8-0/partner-contact-8-0-partner_employee_quantity/it/
* Standard procedure * Adapt dependencies * Adapt menu * Improve view layout * README by fragments * Rise to mature status with maintainer myself
Currently translated at 53.3% (8 of 15 strings) Translation: partner-contact-15.0/partner-contact-15.0-partner_employee_quantity Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_employee_quantity/it/
Currently translated at 93.3% (14 of 15 strings) Translation: partner-contact-15.0/partner-contact-15.0-partner_employee_quantity Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_employee_quantity/sl/
Currently translated at 100.0% (15 of 15 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_employee_quantity Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_employee_quantity/it/
68a48b7
to
f9cbdba
Compare
Migration to 17.0
TT52340
@Tecnativa @chienandalu @carlos-lopez-tecnativa Could you please review this migration and let me know if everything looks correct? Thx!