[REF]pms_api_rest: refactoring of get_alerts_by_day service

OCA · May 6, 2022 · bc24036 · bc24036
1 parent ae20ce1
commit bc24036
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/pms_api_rest/services/pms_calendar_service.py b/pms_api_rest/services/pms_calendar_service.py
@@ -282,19 +282,17 @@ def get_alerts_per_day(self, pms_calendar_search_param):
         for day in (
             date_from + timedelta(d) for d in range((date_to - date_from).days + 1)
         ):
-            overbooking = False
-            lines = self.env["pms.reservation.line"].search(
+            lines = self.env["pms.reservation.line"].search_count(
                 [
                     ("date", "=", day),
                     ("pms_property_id", "=", pms_calendar_search_param.pms_property_id),
+                    ("overbooking", "=", True),
                 ]
             )
-            if any(line.overbooking for line in lines):
-                overbooking = True
             result.append(
                 PmsCalendarAlertsPerDay(
                     date=str(datetime.combine(day, datetime.min.time()).isoformat()),
-                    overbooking=overbooking,
+                    overbooking=True if lines > 0 else False,
                 )
             )
         return result