[14.0] pms website sale #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[IMP] pms_website_sale: Show a very basic list of room types Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be> [IMP] pms_website_sale: Filter improvements Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be> [IMP] pms_website_sale: Images Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be> [REF] pms_website_sale: Use booking engine in controller Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be> [IMP] pms_website_sale: Page for room types Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be> [IMP] pms_website_sale: Load /room page when not logged in During this work, I also realised that pms.room.type is a product, so I incorporated that design, which required some subsequent refactoring. Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be> [IMP] pms_website_sale: Add important comment Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Input are now required, to avoid user entering only one date an not the other. A button has been added to reset the date search.
This commit contains a refactor of the BookingEngineParser.
- Use SESSION_KEY when saving data into session - Discussion about the add_room_request() method and other method - Catch error when casting values from the formular
Errors can now be shown in the log file and properly to the user. On the /rooms page and /booking page
Using URLLookup `model()` does not work for public user as public user has no specific rights on any object. Another way to solve it is to give read rights for pblic user. But that seams dangerous to me as any request made on the website is performed by public user.
Using `price_total` from the `availability_result` does not work as by default in the booking.engine wizard the number of selected rooms (`num_room_selected`) is equal to zero. Therefor the `price_total` is null. To solve that we set the amount of room selected to 1 for each rooms available. As the booking.engine for the rooms page is not stored this is a temporary value that will not be used for booking.
Using route `/rooms` conflict with other pms modules. Now routes for booking online are prefixed `/ebooking`.
When testing to create a folio from an empty parser, the creation of the partner fails because no partner data are present in the parser. This fixes the tests, but it lead to issue in the case when the user bypass the address formular in the booking process.
robinkeunen
force-pushed
the
14.0-pms_website_sale
branch
from
bd24457 to
4fd5079
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
We'd like to submit this WIP module. It allows to book a room online through the portal. The user first lands on the room list. They can filter by room availability based on dates and add a number of rooms to book.
The flow is then similar to the ecommerce flow : review booking (~basket), add extra info, enter address and proceed to payment.
The flow relies on the booking engine to match the availability computed in the backend. A booking engine is created at each request (might cause performance issues).
The folio is only created when the user clicks on pay. It is then cancelled or confirmed based on the online payment status. The invoice is created if the online payment succeeds.
The module adds the following routes :
This is still a work in progress, we just showed the MVP to the customer. Comments and advice are welcome.