Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] ocabot update dotfiles and fix precommit #243

Merged
merged 5 commits into from
Nov 15, 2023
Merged

[14.0] ocabot update dotfiles and fix precommit #243

merged 5 commits into from
Nov 15, 2023

Conversation

robinkeunen
Copy link
Contributor

superseeds #241

@robinkeunen
Copy link
Contributor Author

@bosd @DarioLodeiros

@robinkeunen robinkeunen mentioned this pull request Nov 2, 2023
Merged
4 tasks
@bosd
Copy link
Contributor

bosd commented Nov 2, 2023

Looks like a standard copier update of the repo :)
Please fix the pre-commit.

You might want to enable wkhtmltopdf as it seems that module pms_l10n_es is generating reports.

@robinkeunen robinkeunen force-pushed the 14.0-ocabot-update-dotfiles-roke branch from 8813bd9 to fe5f97e Compare November 2, 2023 17:43
@robinkeunen
Copy link
Contributor Author

@bosd that should be better

bosd
bosd approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apprvoing, as this is supposed to fix ci builds.

@bosd
Copy link
Contributor

bosd commented Nov 15, 2023

@DarioLodeiros Are you a maintainer here? Can you merge?

@DarioLodeiros DarioLodeiros merged commit 0535417 into OCA:14.0 Nov 15, 2023
1 of 4 checks passed
@robinkeunen robinkeunen deleted the 14.0-ocabot-update-dotfiles-roke branch November 15, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarioLodeiros DarioLodeiros DarioLodeiros approved these changes

@bosd bosd bosd approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robinkeunen @bosd @DarioLodeiros @OCA-git-bot