Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] pms: ValueError: Invalid field 'document_type' on model 'pms.fo… #246

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

bosd
Copy link
Contributor

@bosd bosd commented Nov 14, 2023

…lio'

field is removed in commit: b6603a6

@bosd
Copy link
Contributor Author

bosd commented Nov 15, 2023

@DarioLodeiros What do you suggest to do with this PR?

Asking this after your comment that you are planning to update/stabalize the code.
This one is almost done, It only needs squashing/rebase.

Should I still put attention to this? Or do you want to take over?

@DarioLodeiros
Copy link
Member

That's ok, we can do the rebase when you have it. What I was simply referring to is that I will shortly review the tests to update them and stabilize the basis of the pms.

@bosd bosd marked this pull request as ready for review November 15, 2023 17:14
@bosd
Copy link
Contributor Author

bosd commented Nov 15, 2023

Done! Rebased. A little step forward to green ✔️ here.

@DarioLodeiros DarioLodeiros merged commit 6a4832d into OCA:14.0 Nov 16, 2023
1 of 4 checks passed
@bosd bosd deleted the patch-1 branch November 16, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants