Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP]pms: allowd journal filters by room #306

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

DarioLodeiros
Copy link
Member

@DarioLodeiros DarioLodeiros commented Dec 31, 2024

This pull request introduces several changes to the pms module, primarily focusing on adding room filtering capabilities to various models and methods. The most important changes include the addition of new fields to the AccountJournal model, updates to methods to accommodate room filtering, and modifications to the XML views to include the new fields.

Model Updates:

  • Added allowed_room_ids and room_filter_ids fields to the AccountJournal model to filter rooms in reservations (pms/models/account_journal.py).

Method Enhancements:

  • Updated _compute_allowed_room_ids method to compute allowed room IDs based on property IDs (pms/models/account_journal.py).
  • Modified _prepare_invoice method to pass room IDs when getting the default journal (pms/models/pms_folio.py).
  • Enhanced _get_payment_methods method to filter payment methods by room IDs (pms/models/pms_property.py). [1] [2]
  • Updated _get_folio_default_journal method to filter journals by room IDs for both simplified and normal invoices (pms/models/pms_property.py). [1] [2]

View Modifications:

  • Added allowed_room_ids and room_filter_ids fields to the account journal form view (pms/views/account_journal_views.xml).

@DarioLodeiros DarioLodeiros force-pushed the 14.0-pms_journal_filter_room branch from e30b43a to afbac90 Compare December 31, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant