14.0 apply board service by pricelist filter #311
+30
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
pmsmodule, focusing on adding pricelist functionality to board services and improving the logic for handling default board services. The most important changes include adding a new field to thePmsBoardServiceRoomTypemodel, updating constraints and computations involving board services, and modifying views to include the new field.Enhancements to Board Services:
pms/models/pms_board_service_room_type.py: Added a newpricelist_idsfield to thePmsBoardServiceRoomTypemodel to specify the pricelists where the board service is available.pms/models/pms_board_service_room_type.py: Updated theconstrains_duplicated_board_defaultmethod to include the newpricelist_idsfield in the constraint check.Improvements to Reservation Logic:
pms/models/pms_reservation.py: Modified the_compute_board_service_room_idmethod to filter board services based on thepricelist_idsfield, ensuring the correct board service is applied to reservations.pms/wizards/wizard_folio_changes.py: Updated the_add_board_servicemethod to check thepricelist_idsfield when adding board services to reservations.Updates to Views:
pms/views/pms_room_type_views.xml: Added thepricelist_idsfield to the room type views, allowing users to manage pricelists for board services directly from the UI.