[16.0][ADD] pos_product_packaging_multi_barcode #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simahawk
requested changes
Aug 18, 2023
pos_product_packaging_multi_barcode/models/product_packaging.py
Outdated
Show resolved
Hide resolved
QuocDuong1306
force-pushed
the
16.0-add-pos_product_packaging_multi_packaging
branch
2 times, most recently
from
95fb28b to
e05ddf6
Compare
QuocDuong1306
force-pushed
the
16.0-add-pos_product_packaging_multi_packaging
branch
from
e05ddf6 to
4d5f8fc
Compare
|
Hello @simahawk , i updated. Thanks |
|
Happy to do a functional review on this as a bystander, do you have usage steps for this in the README.md? |
QuocDuong1306
force-pushed
the
16.0-add-pos_product_packaging_multi_packaging
branch
from
4d5f8fc to
3002acc
Compare
|
Thank @luke-stdev001 , I updated README.rst file, could you have a look and do a functional review on this module |
|
Dependency merged, you can drop the test req |
QuocDuong1306
force-pushed
the
16.0-add-pos_product_packaging_multi_packaging
branch
from
3002acc to
56d0c68
Compare
|
Thank @simahawk , I updated |
simahawk
reviewed
Oct 10, 2023
QuocDuong1306
force-pushed
the
16.0-add-pos_product_packaging_multi_packaging
branch
from
56d0c68 to
f5a51e6
Compare
simahawk
reviewed
Oct 12, 2023
| Object.values(old_packaging_by_barcode).forEach(function (packaging) { | ||
| var barcodes = JSON.parse(packaging.barcodes_json); | ||
| barcodes.forEach(function (barcode) { | ||
| if (!(barcode in old_packaging_by_barcode)) { |
There was a problem hiding this comment.
IMO this IF is not needed. Not harmful tho. Not blocking.
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at c13b28e. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module allows using multiple barcodes on a product packaging from the PoS.
Depends on: