-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][FIX] pos_order_mgmt: Return with positive amounts #1067
[14.0][FIX] pos_order_mgmt: Return with positive amounts #1067
Conversation
I've checked it and I've noticed that when trying to delete a line an error appears: |
4d71319
to
a879333
Compare
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality checked, all ok
The sign of a return is forced to be negative so that it does not give an error later when confirming the order. In addition, a confirmation message is added in the event of returning more than the quantity sold.
a879333
to
04289c1
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
/ocabot merge patch |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 07c91e0. Thanks a lot for contributing to OCA. ❤️ |
When making a return, the POS user can change the return quantity into positive. If the user does not realise this, the error message "Please specify at least one non-zero quantity" is displayed at the end of the order. leaving the order to be synchronised, always giving the same error.
I propose that when making the return from the POS, this line should always be forced to a negative amount.
In addition, a ConfirmPopup has been added to make sure that the user is aware that he is making a return of more than the amount sold.