Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] pos_order_mgmt: Return with positive amounts #1067

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

zamberjo
Copy link
Member

When making a return, the POS user can change the return quantity into positive. If the user does not realise this, the error message "Please specify at least one non-zero quantity" is displayed at the end of the order. leaving the order to be synchronised, always giving the same error.

I propose that when making the return from the POS, this line should always be forced to a negative amount.

In addition, a ConfirmPopup has been added to make sure that the user is aware that he is making a return of more than the amount sold.

@belenaures
Copy link

I've checked it and I've noticed that when trying to delete a line an error appears:
-> what i do is to is press the delete button in the POS, first it remains as qty 0 and then it should delete the line, instead, the error shows.
Rastreo de error: Error: 'remove' no es un decimal correcto at Object.parseFloat [as float

@zamberjo zamberjo force-pushed the 14.0-fix-return-positive-quantity branch from 4d71319 to a879333 Compare October 30, 2023 10:46
@zamberjo
Copy link
Member Author

I've checked it and I've noticed that when trying to delete a line an error appears: -> what i do is to is press the delete button in the POS, first it remains as qty 0 and then it should delete the line, instead, the error shows. Rastreo de error: Error: 'remove' no es un decimal correcto at Object.parseFloat [as float

Fixed

Copy link

@belenaures belenaures left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality checked, all ok

The sign of a return is forced to be negative so that it does not give
an error later when confirming the order. In addition, a confirmation
message is added in the event of returning more than the quantity sold.
@zamberjo zamberjo force-pushed the 14.0-fix-return-positive-quantity branch from a879333 to 04289c1 Compare January 23, 2024 12:06
@legalsylvain legalsylvain added this to the 14.0 milestone Feb 21, 2024
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 23, 2024
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1067-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4067b44 into OCA:14.0 Jun 24, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 07c91e0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants