Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] pos_partner_birthdate: Fixing conflict t-model vs t-att-value #1072

Merged
merged 1 commit into from
Nov 13, 2023
Merged

[16.0][FIX] pos_partner_birthdate: Fixing conflict t-model vs t-att-value #1072

merged 1 commit into from
Nov 13, 2023

Conversation

imbarbudiman
Copy link
Contributor

@imbarbudiman imbarbudiman commented Nov 2, 2023 •
edited
Loading

After merged this PR #1071 now changes.birthdate_date is reactive.
If we use t-model, there is no need to use the t-att-value, because this will cause abnormal behavior.

Before this changes:
Before del t-att-value

After this changes:
After del t-att-value

@OCA-git-bot
Copy link
Contributor

Hi @ecino,
some modules you are maintaining are being modified, check this out!

@chienandalu chienandalu requested a review from ecino November 2, 2023 16:11
@chienandalu chienandalu added this to the 16.0 milestone Nov 2, 2023
chienandalu
chienandalu approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @imbarbudiman :)

@chienandalu
Copy link
Member

Hi @ecino would you add your review?

@chienandalu chienandalu mentioned this pull request Nov 8, 2023
Closed
ecino
ecino approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@ecino ecino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@chienandalu
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1072-by-chienandalu-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6f41af1 into OCA:16.0 Nov 13, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 006cd2c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecino ecino ecino approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved bug merged 🎉 needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@imbarbudiman @OCA-git-bot @chienandalu @ecino