Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][FIX] pos_report_session_summary: fix error when printing #1093

Conversation

almumu
Copy link
Member

@almumu almumu commented Nov 24, 2023

Is not possible to print the report. This pr fixes the error: 'str' object has no attribute 'decimal_places' when printing session summary

… 'str' object has no attribute 'decimal_places' when printing session summaryossible to print the report. This pr fixes the error: 'str' object has no attribute 'decimal_places' when printing session summary
@almumu almumu force-pushed the 15.0_pos_report_session_summary_fix_report_error branch from 070595a to 728225c Compare November 24, 2023 07:58
@almumu
Copy link
Member Author

almumu commented Nov 24, 2023

this solves #1092

Copy link
Contributor

@anmarmo1 anmarmo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review is ok.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As these fields are monetary we don't need indeed these t-options. The problem thou was that the display_currency value was a string instead of the value itself, as it was addressed in #1075

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-1093-by-chienandalu-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 18, 2023
Signed-off-by chienandalu
@OCA-git-bot
Copy link
Contributor

@chienandalu your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1093-by-chienandalu-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@ivantodorovich
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@ivantodorovich The rebase process failed, because command git push --force aurestic tmp-pr-1093:15.0_pos_report_session_summary_fix_report_error failed with output:

remote: Permission to aurestic/pos.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/aurestic/pos/': The requested URL returned error: 403

@ivantodorovich
Copy link
Contributor

@almumu could you rebase your branch, please?

It seems there was an error during the last merge attempt

@ivantodorovich
Copy link
Contributor

/ocabot merge patch

Let's try again

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1093-by-ivantodorovich-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 966e200 into OCA:15.0 Dec 18, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 81e500c. Thanks a lot for contributing to OCA. ❤️

@zamberjo zamberjo deleted the 15.0_pos_report_session_summary_fix_report_error branch December 21, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants