-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][FIX] pos_report_session_summary: fix error when printing #1093
[15.0][FIX] pos_report_session_summary: fix error when printing #1093
Conversation
… 'str' object has no attribute 'decimal_places' when printing session summaryossible to print the report. This pr fixes the error: 'str' object has no attribute 'decimal_places' when printing session summary
070595a
to
728225c
Compare
this solves #1092 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review is ok.
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As these fields are monetary we don't need indeed these t-options
. The problem thou was that the display_currency
value was a string instead of the value itself, as it was addressed in #1075
/ocabot merge patch
Hey, thanks for contributing! Proceeding to merge this for you. |
@chienandalu your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1093-by-chienandalu-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot rebase |
@ivantodorovich The rebase process failed, because command
|
@almumu could you rebase your branch, please? It seems there was an error during the last merge attempt |
/ocabot merge patch Let's try again |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 81e500c. Thanks a lot for contributing to OCA. ❤️ |
Is not possible to print the report. This pr fixes the error: 'str' object has no attribute 'decimal_places' when printing session summary