Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] pos_lot_barcode: Migration to 16.0 #934

Merged
merged 5 commits into from
Feb 28, 2023
Merged

[16.0][MIG] pos_lot_barcode: Migration to 16.0 #934

merged 5 commits into from
Feb 28, 2023

Conversation

yankinmax
Copy link
Contributor

@yankinmax yankinmax commented Feb 27, 2023 •
edited
Loading

Tested functionally and compared with v15

@yankinmax yankinmax mentioned this pull request Feb 27, 2023
Closed
@yankinmax yankinmax force-pushed the 16.0-mig-pos_lot_barcode branch from f73a759 to c7037ba Compare February 28, 2023 08:33
@yankinmax yankinmax mentioned this pull request Feb 28, 2023
Open
38 tasks
Camille0907
Camille0907 approved these changes Feb 28, 2023
View reviewed changes
Copy link

@Camille0907 Camille0907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a technical point of view, but not tested functionnaly

ivantodorovich
ivantodorovich approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically LG

@ivantodorovich
Copy link
Contributor

/ocabot migration pos_lot_barcode

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Feb 28, 2023
@OCA-git-bot
Copy link
Contributor

The migration issue (#849) has been updated to reference the current pull request.
however, a previous pull request was referenced : #918.
Perhaps you should check that there is no duplicate work.
CC : @juliette-blanc

@yankinmax yankinmax force-pushed the 16.0-mig-pos_lot_barcode branch from c7037ba to 405fa93 Compare February 28, 2023 15:03
@ivantodorovich
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-934-by-ivantodorovich-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 28, 2023
@OCA-git-bot
Merge PR #934 into 16.0
c64e6cc 
Signed-off-by ivantodorovich
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-934-by-ivantodorovich-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6f0a645 into OCA:16.0 Feb 28, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f692a56. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Camille0907 Camille0907 Camille0907 approved these changes

@ivantodorovich ivantodorovich ivantodorovich approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yankinmax @ivantodorovich @OCA-git-bot @Camille0907 @grindtildeath