[16.0][MIG] kpi: Migration to 16.0 #920
Conversation
* kpi migration to odoo 9 * UI error connected * Correction base on last maxime review * correction on @elicoidal review * Warning exception improve in kpi_threshold * Latest Ellicoidal comment implemented * last Ellicoial recommendation done. * Copyright corrected
Currently translated at 100.0% (68 of 68 strings) Translation: reporting-engine-12.0/reporting-engine-12.0-kpi Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-kpi/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-kpi Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-kpi/
Currently translated at 100.0% (79 of 79 strings) Translation: reporting-engine-12.0/reporting-engine-12.0-kpi Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-kpi/pt_BR/
kpi/models/kpi.py
Outdated
| kpi_type = fields.Selection( | ||
| [ | ||
| ("python", "Python"), | ||
| ("local", "SQL - Local DB"), |
There was a problem hiding this comment.
according L122 this must be 'local' --> 'sql'
kpi/models/kpi.py
Outdated
| [ | ||
| ("python", "Python"), | ||
| ("local", "SQL - Local DB"), | ||
| ("external", "SQL - External DB"), |
kpi/models/kpi.py
Outdated
|
|
||
| next_execution_date = fields.Datetime(readonly=True) | ||
| value = fields.Float(compute="_compute_display_last_kpi_value") | ||
| color = fields.Text(compute="_compute_display_last_kpi_value") |
There was a problem hiding this comment.
because we're removing threshold to simplify the module, color should not exist
matiasperalta1
force-pushed
the
16.0-t-30706-mnp
branch
from
b5bfd94 to
a087f91
Compare
| <field name="next_execution_date" colspan="3" /> | ||
| <separator string="KPI Computation" colspan="6" /> | ||
| <newline /> | ||
| <field name="kpi_type" colspan="2" /> |
There was a problem hiding this comment.
It would be better to have colspan equal to "6" in order to have both kpi_type and kpi_code one bellow the other. Another option could be creating two diff groups
With colspan = "2" , the code's label is in the same line as kpi_type and the editable field bellow, what makes the label confusing.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
No description provided.