Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] report_qweb_pdf_watermark: support pypdf >= 2.0 #951

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Nov 27, 2024

@risto42
Copy link

risto42 commented Jan 10, 2025

Well, according to https://pypdf2.readthedocs.io/en/3.x/

PyPDF2 is deprecated, please use pypdf

@thomaspaulb
Copy link

PyPDF2 is deprecated, please use pypdf

Right, but all this also applies to version 2 of pypdf: https://pypdf.readthedocs.io/en/latest/user/migration-1-to-2.html

@risto42
Copy link

risto42 commented Jan 12, 2025

PyPDF2 is deprecated. PyPDF can support OCB v16 minimal version of python (3.7) with a version prior to PyPDF-5.0.0,
no problem with recent versions.
There is no reason to put off a trivial migration complicating things further.
This applies for all PyPDF2 usage in OCA as well as in OCB.

@thomaspaulb
Copy link

@hbrunn It makes sense - why are we still importing pypdf2 and not pypdf ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants