Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] sale_order_secondary_unit: Migration to 16.0 #2635

Closed
wants to merge 35 commits into from
Closed

[16.0][MIG] sale_order_secondary_unit: Migration to 16.0 #2635

wants to merge 35 commits into from

Conversation

anddago78
Copy link

This module extends the functionality of sale orders to allow sale products in
secondary unit of distinct category.

MT-3490 @moduon @rafaelbn @EmilioPascual @fcvalgar please reviews :)

sergio-teruel and others added 30 commits August 4, 2023 12:59
@sergio-teruel
[11.0][NEW] sale_order_secondary_unit: New module for sale in a secon…
9e36da0 
…dary product unit
@sergio-teruel
[11.0][FIX] sale_order_secondary_unit: define sale secondary uom in t…
e3f5730 
…his module instead of product_secondary_unit
[11.0][IMP/FIX] sale_secondary_unit limit secondary uom in order line
2897653 
Added domain to limit `secondary_uom_id` to the one defined in product template
@sergio-teruel
[11.0][IMP] sale_secondary_unit: Set secondary uom quantity as 1.0 by…
f6f740c 
… default
@sergio-teruel
[11.0][IMP] sale_order_secondary_unit: Add security group
19ed41d
@sergio-teruel
[11.0][IMP] sale_order_secondary_unit: add secondary unit to sale report
a967774
@marylla
Added translation using Weblate (German)
9b4b2fe
@digitalsatori
[MIG] sale_order_secondary_unit: Migration to 12.0
f914a5c
@ThomasBinsfeld
[MIG] migrate sale_order_secondary_unit from 12.0 to 13.0
38b6516
@alexeirivera87
[MIG] sale_order_secondary_unit: Migration to 14.0
5585406
@mourad-ehm
[FIX] code refactor
5261812
@Kev-Roche
code refactor update
2121caa
@Kev-Roche
add secondary price unit
3e1f79b
@Kev-Roche
[FIX] ZeroDivisionError when qty is null
db4aff7
@victoralmau
[IMP] sale_order_secondary_unit: Add name to th/td element + span (im…
77ebcd8 
…prove inheritance).

TT36255
@remihb
[MIG] sale_order_secondary_unit: Migration to 15.0
6206dc1
@sergio-teruel
[FIX] sale_order_secondary_unit: Fix variant grid matrix usage
1a47313
[UPD] Update sale_order_secondary_unit.pot
ec1b9aa
@OCA-git-bot
[UPD] README.rst
9b6a96d
@sergio-teruel
[FIX] sale_order_secondary_unit: Fix incorrect header position inheri…
f42ab8a 
…tance

TT40001
@OCA-git-bot
sale_order_secondary_unit 15.0.1.1.0
4c0e084
@sergio-teruel
[MIG] sale_stock_secondary_unit: Migration to v15.0
243f07b
@OCA-git-bot
[UPD] README.rst
afde7eb
[FIX] sale_order_secondary_unit: Make test resilient
369f95b 
As the test should only test that no change on the UoM quantity is done
when modifying the secondary unit, we remember the existing quantity and
compare it later with the final value, instead of testing against a
fixed value, so any interaction with other modules don't interfere.
@OCA-git-bot
sale_order_secondary_unit 15.0.1.1.1
b3f7fe1
[IMP] sale_order_secondary_unit: Add menu for secondary UoM
0b8c5d6
[UPD] Update sale_order_secondary_unit.pot
04fee71
@OCA-git-bot
[UPD] README.rst
07267b3
@OCA-git-bot
sale_order_secondary_unit 15.0.1.2.0
b770a79
@weblate
Update translation files
58ad130 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_secondary_unit
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_secondary_unit/
@anddago78 anddago78 changed the title [16.0][MIG] sale_order_secondary_unit [16.0][MIG] sale_order_secondary_unit: Migration to 16.0 Aug 10, 2023
@rafaelbn
Copy link
Member

/ocabot migration sale_order_secondary_unit

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Aug 10, 2023
@OCA-git-bot
Copy link
Contributor

The migration issue (#2215) has not been updated to reference the current pull request because a previous pull request (#2486) is not closed.
Perhaps you should check that there is no duplicate work.
CC @remihb

@rafaelbn rafaelbn mentioned this pull request Aug 10, 2023
Closed
1 task
@rafaelbn
Copy link
Member

/ocabot migration sale_order_secondary_unit

@OCA-git-bot OCA-git-bot mentioned this pull request Aug 10, 2023
Open
@rafaelbn rafaelbn requested a review from fcvalgar August 10, 2023 10:13
@rafaelbn
Copy link
Member

CI errors are not related to this module

2021-10-02 15:30:00,000 250 ERROR odoo odoo.addons.sale_order_product_recommendation.tests.test_recommendation: FAIL: RecommendationCaseTests.test_recommendations_last_sale_price_to_sale_order Traceback (most recent call last): File "/__w/sale-workflow/sale-workflow/sale_order_product_recommendation/tests/test_recommendation.py", line 157, in test_recommendations_last_sale_price_to_sale_order self.assertEqual(so_line_prod1.price_unit, 24.50) AssertionError: 25.0 != 24.5

2023-08-10 09:28:40,273 250 ERROR odoo odoo.addons.sale_order_qty_change_no_recompute.tests.test_sale_order_qty_change: FAIL: TestSaleOrderQtyChange.test_sale_line_misc Traceback (most recent call last): File "/__w/sale-workflow/sale-workflow/sale_order_qty_change_no_recompute/tests/test_sale_order_qty_change.py", line 37, in test_sale_line_misc self.assertEqual(self.line_form.price_subtotal, 60) AssertionError: 30.0 != 60

Ready to review!

fcvalgar
fcvalgar approved these changes Aug 10, 2023
View reviewed changes
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review.
LGTM, thank you @anddago78

https://www.loom.com/share/d5f6917a8a624fb99b31e2a047b71464?sid=16e2b4eb-8935-4619-82e0-7a3b21a5eae7

@rafaelbn
Copy link
Member

Hello @sergio-teruel ! Do you want to take a look! 😄 🙏🏼 ❤️ Thank you!

@sergio-teruel
Copy link
Contributor

I am seeing that this commit from v15 is missing
https://github.com/OCA/sale-workflow/pull/2331/files#diff-4d7e4714e57f20ebf63b3686c00dd4a264e9d3abab40e1b37eafc66f0dcf16e4

Please review your work... all changes are in v15, so I think that your origin is not at date...

@sergio-teruel
Copy link
Contributor

In these commit the test of module sale_order_qty_change_no_recompute was fixed... but in your migration I do not see these fix

@rafaelbn
Copy link
Member

Hello @anddago78 !

Thank you for this migration ❤️

Please:

  • Attend comments of Sergio, I guess to followed the Migration to versión 16 OCA Guidelines, and somthing were wrong in the process. Could you you please repeat the process in the same PR?

  • I've tested the module in Odoo 15 and this PR in Odoo 16 and this PR has a BUG because the "subtotal prices" are not updating when changing the invoicing uom when in Odoo.com runbit it works perfect. I've recorded a video where you can when this BUG and in the las 15 seconds of the video you will see how it works perfect in runbot of odoo.com. Note: in OCA 15 this module updates the price perfectly :-D

Odoo16.-.sale_order_product_secondary_unit.-.rafaelbn.functional.test.mp4
Odoo.15.-.sale_order_product_secondary_unit.-.rafaelbn.functional.test.mp4

Thank you! Let's rock! ⭐ 🚀

@anddago78 anddago78 closed this Aug 18, 2023
@rafaelbn rafaelbn mentioned this pull request Aug 18, 2023
Closed
3 tasks
@rafaelbn
Copy link
Member

Superseed by #2645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcvalgar fcvalgar fcvalgar approved these changes

Assignees
No one assigned
Labels
needs fixing
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.