Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] sale_discount_display_amount: Migration to 17.0 #3026

Closed
wants to merge 53 commits into from
Closed

[MIG] sale_discount_display_amount: Migration to 17.0 #3026

wants to merge 53 commits into from

Conversation

FSchiepers
Copy link

This version adds the possibility to choose whether the discount is calculated based on the non-taxed subtotal or the taxed total, see: #2813

Correction from #2987

Cédric Pigeon and others added 30 commits March 18, 2024 11:52
@FSchiepers
[ADD] add new module to display discount amount on sale orders
6a66157
@oca-travis @FSchiepers
[UPD] Update sale_discount_display_amount.pot
b88907d
@OCA-git-bot @FSchiepers
[UPD] README.rst
0853d60
@FSchiepers
Added translation using Weblate (French)
95bc881
@FSchiepers
Added translation using Weblate (Spanish)
cd1efae
@Abranes @FSchiepers
[12.0][MIG] sale_discount_display_amount
9af07f6
@OCA-git-bot @FSchiepers
[UPD] README.rst
4be8431
@oca-travis @FSchiepers
[UPD] Update sale_discount_display_amount.pot
48beb1c
@oca-transbot @FSchiepers
Update translation files
ab4c8c2 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_discount_display_amount/
@marylla @FSchiepers
Added translation using Weblate (German)
6b9c56f
@marylla @FSchiepers
Translated using Weblate (German)
af016a1 
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_discount_display_amount/de/
@OCA-git-bot @FSchiepers
[UPD] README.rst
9bb7adc
@liweijie0812 @FSchiepers
Added translation using Weblate (Chinese (Simplified))
9683b24
@liweijie0812 @FSchiepers
Translated using Weblate (Chinese (Simplified))
c5b7a46 
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_discount_display_amount/zh_CN/
@FSchiepers
[IMP] sale_discount_display_amount: black, isort
5cd1a3e
@FSchiepers
[MIG] sale_discount_display_amount: Migration to 13.0
03b9621
@lmignon @FSchiepers
[MIG] sale_discount_display_amount: Computed values must be reset by …
26104ca 
…the compute method
@FSchiepers
[IMP] sale_discount_display_amount rename view
0f25030
@oca-travis @FSchiepers
[UPD] Update sale_discount_display_amount.pot
fd2bb41
@OCA-git-bot @FSchiepers
[UPD] README.rst
1d7f05c
@oca-transbot @FSchiepers
Update translation files
6982e36 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_discount_display_amount/
@OCA-git-bot @FSchiepers
pre-commit update
4377aba
@pedrobaeza @FSchiepers
[FIX] sale_discount_display_amount: Guidelines in compute methods names
bf6d6d8 
If not, it can collide with other modules defining the same compute name, so let's
follow the guidelines and name properly the method.
@danimv5 @FSchiepers
Translated using Weblate (Spanish)
ff09d8a 
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_discount_display_amount/es/
@chafique-delli @FSchiepers
[MIG] sale_discount_display_amount: Migration to 14.0
8fe1067 
[FIX] README.rst
@oca-travis @FSchiepers
[UPD] Update sale_discount_display_amount.pot
9dd0071
@OCA-git-bot @FSchiepers
[UPD] README.rst
e63ae11
@OCA-git-bot @FSchiepers
sale_discount_display_amount 14.0.1.0.1
89033f2
@bosd @FSchiepers
Added translation using Weblate (Dutch)
5634baf
@bosd @FSchiepers
Translated using Weblate (Dutch)
1a7ba39 
Currently translated at 100.0% (7 of 7 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_discount_display_amount/nl/
OCA-git-bot and others added 9 commits March 18, 2024 11:52
@OCA-git-bot @FSchiepers
sale_discount_display_amount 15.0.1.0.1
7469f9a
@mymage @FSchiepers
Translated using Weblate (Italian)
cb7ea40 
Currently translated at 100.0% (7 of 7 strings)

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_discount_display_amount/it/
@FSchiepers
[MIG] sale_discount_display_amount: Migration to 16.0
1122e37
@FSchiepers
[UPD] Update sale_discount_display_amount.pot
917823e
@OCA-git-bot @FSchiepers
[UPD] README.rst
434dc9d
@weblate @FSchiepers
Update translation files
608da57 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_discount_display_amount/
@francesco-ooops @FSchiepers
Translated using Weblate (Italian)
38db790 
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_discount_display_amount/it/
@OCA-git-bot @FSchiepers
[UPD] README.rst
bfc270e
@FSchiepers
[MIG] sale_discount_display_amount: Migration to 17.0
c8118c6
@FSchiepers
Copy link
Author

/ocabot migration sale_discount_display_amount

@OCA-git-bot
Copy link
Contributor

Sorry @FSchiepers you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@rousseldenis
Copy link
Contributor

/ocabot migration sale_discount_display_amount

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Mar 18, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 18, 2024
Open
84 tasks
rousseldenis
rousseldenis requested changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

IMHO changes in the module should be done in a separate commit in order to separate the real migration and the improvements.

sale_discount_display_amount/__manifest__.py Outdated Show resolved Hide resolved
sale_discount_display_amount/hooks.py Outdated Show resolved Hide resolved
@FSchiepers FSchiepers requested a review from rousseldenis March 19, 2024 12:38
@rousseldenis
Copy link
Contributor

@FSchiepers Could you improve your commit messages :

image

Something like [IMP] sale_discount_display_amount: (...)

Thanks

FSchiepers
FSchiepers commented Apr 16, 2024
View reviewed changes
sale_discount_display_amount/hooks.py
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[IMP]sale_discount_display_amount: : renamed Logger to _logger

FSchiepers

This comment was marked as duplicate.

Sign in to view

FSchiepers
FSchiepers commented Apr 16, 2024
View reviewed changes
Copy link
Author

@FSchiepers FSchiepers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[IMP] sale_discount_display_amount: Removed all the standard parameters.

@FSchiepers
Copy link
Author

I added comments, can you review please?

@FSchiepers FSchiepers closed this May 23, 2024
@FSchiepers FSchiepers deleted the 17.0-mig-sale_discount_display_amount branch May 23, 2024 11:12
@FSchiepers FSchiepers restored the 17.0-mig-sale_discount_display_amount branch May 29, 2024 09:47
@FSchiepers FSchiepers deleted the 17.0-mig-sale_discount_display_amount branch May 29, 2024 11:49
@FSchiepers
Copy link
Author

rebased to #3160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis Awaiting requested review from rousseldenis

Assignees
No one assigned
Labels
migration needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.