Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] sale_automatic_workflow_stock: Migration to 18.0 #3447

Open
wants to merge 6 commits into
base: 18.0
Choose a base branch
from

Conversation

chaule97
Copy link

@chaule97 chaule97 commented Dec 3, 2024

  • Depend on: sale_automatic_workflow: Migration to 18.0
  • This migration includes the integration of the sale_automatic_workflow_delivery_state module. The all_qty_delivered field from the sale_automatic_workflow module will now rely on the delivery_status field in the sale_stock module for its calculations

@rousseldenis
Copy link
Contributor

/ocabot migration sale_automatic_workflow_stock

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Dec 3, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 3, 2024
50 tasks
@chaule97 chaule97 force-pushed the 18.0-mig-sale_automatic_workflow_stock branch from a2bccd3 to 86a04c9 Compare December 5, 2024 04:42
@chaule97 chaule97 force-pushed the 18.0-mig-sale_automatic_workflow_stock branch from 86a04c9 to 824b418 Compare December 12, 2024 08:42
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, minor comment

sale_automatic_workflow_stock/tests/common.py Outdated Show resolved Hide resolved
@chaule97 chaule97 force-pushed the 18.0-mig-sale_automatic_workflow_stock branch from 824b418 to 7fc781b Compare December 24, 2024 04:13
SButko and others added 6 commits January 9, 2025 11:03
There is an issue for service companies that do not need the stock
module to be installed when using `sale_automatic_workflow`. Module
depended on `stock`, therefore it was auto installed. Now, stock related
part is moved to a separate module - `sale_automatic_workflow_stock` and
can be installed separately.
Currently translated at 100.0% (13 of 13 strings)

Translation: sale-workflow-17.0/sale-workflow-17.0-sale_automatic_workflow_stock
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_automatic_workflow_stock/it/
@chaule97 chaule97 force-pushed the 18.0-mig-sale_automatic_workflow_stock branch from 7fc781b to e8d6854 Compare January 9, 2025 04:03
@@ -0,0 +1 @@
The migration of this module from 17.0 to 18.0 was financially supported by Camptocamp.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only my opinion, but I think this is a pretty trivial module migration and if everytime someone migrates a modules he starts adding a section like that telling company X put the money for it, then the OCA appstore will quickly end up like the click bait blinking gifs of Odoo appstore. This is a bit concerning if Camptocamp starts showing some bad example here... I mean come on guys this doesn't scale if every little trivial migration start doing that... we need some self moderation and common sense... Eventually you guys can try to push so that the OCA better emphatize the modules authors, contributors and maintainers and this is a place where CampToCamp already shines. But starting to add such sections for trivial migrations is just commercial noise that doesn't scale IMHO.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree, this CREDITS fragment is here for that reason. And IMO even a migration that doesn't introduce big changes to work on a new version, requires in fact some burden: checking every pieces of code extending the Odoo std if they are still OK, testing and making sure it works as expected.

And IMO we should get only one migration text regarding this for a given version, for Odoo 19.0 the "17.0 to 18.0" sentence should be removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This discussion belongs on the contributors mailing list, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants