[18.0][MOV] product_set_sell_only_by_packaging: Migration to 18.0 #3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[18.0][UPD] Copier update
FIX case of tests DEL refund journal field on sale order type, now same invoice journal should be used for refunds FIX case of test FIX sale order test
Conflicts: sale_order_type/models/sale_order.py sale_order_type/models/stock_picking.py sale_order_type/tests/test_sale_order_type.py ADD Payment Term, Pricelist and Incoterm to sale order type Conflicts: sale_order_type/models/sale_order.py sale_order_type/tests/test_sale_order_type.py sale_order_type/views/sale_order_type_view.xml ADD sale type for invoices Conflicts: sale_order_type/README.rst sale_order_type/models/account_invoice.py sale_order_type/tests/test_sale_order_type.py IMP description
ADD multicompany rule for sale.order.type and company in sale.order.type (OCA#292) [IMP] sale_order_type: multicompany handle Conflicts: sale_order_type/models/sale_order_type.py
[UPD] Update sale_order_type.pot
When * packaging cannot be sold anymore * lines are tied to a product that can be sold only by packaging and have no packaging change the packaging on the line to the 1st saleable packaging.
Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_product_set_sale_by_packaging Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_product_set_sale_by_packaging/es/
trisdoan
force-pushed
the
18.0-mig-sale_product_set_sale_by_packaging
branch
from
9d43c74 to
e5f87ca
Compare
jbaudoux
reviewed
Dec 30, 2024
There was a problem hiding this comment.
Shouldn't this module be renamed to sale_product_set_sell_only_by_packaging ?
And in regards of my comment #3474 (review) maybe it should just be product_set_sell_only_by_packaging as I don't see any sales feature in this module
| """, | ||
| "version": "18.0.1.0.0", | ||
| "development_status": "Alpha", | ||
| "category": "Warehouse Management", |
There was a problem hiding this comment.
Suggested change
| "category": "Warehouse Management", | |
| "category": "Sales", |
| { | ||
| "name": "Sale Product Set Sale by packaging", | ||
| "summary": """ | ||
| Glue module between `sale_by_packaging` and `sale_product_set_packaging_qty`. |
There was a problem hiding this comment.
Suggested change
| Glue module between `sale_by_packaging` and `sale_product_set_packaging_qty`. | |
| Glue module between `sell_only_by_packaging` and `sale_product_set_packaging_qty`. |
| # @author Simone Orsi <simone.orsi@camptocamp.com> | ||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl) | ||
| { | ||
| "name": "Sale Product Set Sale by packaging", |
There was a problem hiding this comment.
Suggested change
| "name": "Sale Product Set Sale by packaging", | |
| "name": "Sales Product set Sell only by packaging", |
trisdoan
force-pushed
the
18.0-mig-sale_product_set_sale_by_packaging
branch
from
e5f87ca to
bb61de7
Compare
Hello @jbaudoux, agreed, I renamed the module, thank you so much |
|
|
trisdoan
force-pushed
the
18.0-mig-sale_product_set_sale_by_packaging
branch
from
bb61de7 to
5b57ad5
Compare
trisdoan
changed the title
Renamed from sale_product_set_sale_by_packaging to product_set_sell_only_by_packaging
trisdoan
force-pushed
the
18.0-mig-sale_product_set_sale_by_packaging
branch
from
5b57ad5 to
3ada4e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Changes in 18.0
sale_product_set_sale_by_packagingtoproduct_set_sell_only_by_packagingcan_be_soldis now replaced by standard Odoo field:sales, which was introduced from 15.0 in odoo/odoo@a2b207cgroup_discount_per_so_linewas moved to module sale in here odoo/odoo@82eb2b5sell_only_by_packagingwritable in object ProductSetLine to bypass oca-ci testsale_by_packagingwas stopped to migrate since 15.0,sell_only_by_packagingwas introduced to replace, inhttps://github.com/OCA/sale-workflow/pull/2623, which is migrated to 18.0 in